From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 0/2] Preserve hard links
Date: Wed, 09 Feb 2011 12:20:09 +0000 [thread overview]
Message-ID: <1297254009.1395.6899.camel@rex> (raw)
In-Reply-To: <cover.1297230569.git.mark.hatle@windriver.com>
On Tue, 2011-02-08 at 23:51 -0600, Mark Hatle wrote:
> While working on another part of the system, I noticed that Poky didn't appear
> to be preserving any hard links in the system. This change not only
> preserves hardlinks during packaging, but also shrinks the overall
> disk space required for a build. In my poky-image-minimal my required
> footprint shank by 200+ MB.
>
> The second part of this patch I took a guess as to the right components to
> modify. It has passed the testing I've performed so far, but I'm not
> 100% sure that it's correct. I believe a bit of additional review may be
> necessary.
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
> Branch: mhatle/hardlink
> Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=mhatle/hardlink
This looks good, my main worry is the copytree() function in
meta/lib/oe/path.py as I suspect that will still smash things for
sstate.
I'm seriously considering making that function an os.system call to tar
as I suspect performance would improve substantially. I need some
numbers to back up that idea first though.
I'm probably going to hold off on these patches for 24 hours as there is
risk in them, I'd like to fix the above issue too and at the moment I
want to see us have a "successful" build and stabilise a bit after the
fetcher churn.
Cheers,
Richard
next prev parent reply other threads:[~2011-02-09 12:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 5:51 [PATCH 0/2] Preserve hard links Mark Hatle
2011-02-09 5:51 ` [PATCH 1/2] package.bbclass: Preserve hard links! Mark Hatle
2011-02-09 5:51 ` [PATCH 2/2] Misc hard link fixes Mark Hatle
2011-02-09 12:20 ` Richard Purdie [this message]
2011-02-09 13:10 ` [PATCH 0/2] Preserve hard links Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297254009.1395.6899.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=mark.hatle@windriver.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.