All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: mjg@redhat.com
Cc: iss_storagedev@hp.com,
	"Stephen M. Cameron" <scameron@beardog.cce.hp.com>,
	linux-scsi@vger.kernel.org
Subject: [PATCH 1/2] hpsa: Disable ASPM
Date: Wed,  9 Feb 2011 13:07:10 -0500	[thread overview]
Message-ID: <1297274831-10405-1-git-send-email-mjg@redhat.com> (raw)

https://bugzilla.redhat.com/show_bug.cgi?id=618612 indicates that current
hpsa hardware has problems if ASPM is enabled. Disable it to avoid crashes.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
Cc: iss_storagedev@hp.com
Cc: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: linux-scsi@vger.kernel.org
---
 drivers/scsi/hpsa.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 12deffc..30fb46a 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -23,6 +23,7 @@
 #include <linux/interrupt.h>
 #include <linux/types.h>
 #include <linux/pci.h>
+#include <linux/pci-aspm.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/delay.h>
@@ -3733,6 +3734,9 @@ static int __devinit hpsa_init_one(struct pci_dev *pdev,
 	if (number_of_controllers == 0)
 		printk(KERN_INFO DRIVER_NAME "\n");
 
+	pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S | PCIE_LINK_STATE_L1 |
+			       PCIE_LINK_STATE_CLKPM);
+
 	rc = hpsa_init_reset_devices(pdev);
 	if (rc)
 		return rc;
-- 
1.7.4


             reply	other threads:[~2011-02-09 18:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09 18:07 Matthew Garrett [this message]
2011-02-09 18:07 ` [PATCH 2/2] cciss: Disable ASPM Matthew Garrett
2011-02-09 20:35   ` Miller, Mike (OS Dev)
2011-02-09 20:45     ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297274831-10405-1-git-send-email-mjg@redhat.com \
    --to=mjg@redhat.com \
    --cc=iss_storagedev@hp.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=scameron@beardog.cce.hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.