All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux@audioscience.com
To: patch@alsa-project.org
Cc: tiwai@suse.de,
	Eliot Blennerhassett <eblennerhassett@audioscience.com>,
	alsa-devel@alsa-project.org
Subject: [PATCH 07/28] Add adapter index to cache info for debug.
Date: Thu, 10 Feb 2011 17:26:00 +1300	[thread overview]
Message-ID: <1297311981-30448-8-git-send-email-linux@audioscience.com> (raw)
In-Reply-To: <1297311981-30448-1-git-send-email-linux@audioscience.com>

From: Eliot Blennerhassett <eblennerhassett@audioscience.com>

Signed-off-by: Eliot Blennerhassett <eblennerhassett@audioscience.com>
---
 pci/asihpi/hpi6000.c |    3 +++
 pci/asihpi/hpi6205.c |    3 +++
 pci/asihpi/hpicmn.c  |   16 ++++++++++++----
 pci/asihpi/hpicmn.h  |    3 ++-
 4 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/pci/asihpi/hpi6000.c b/pci/asihpi/hpi6000.c
index c85db49..c486af1 100644
--- a/pci/asihpi/hpi6000.c
+++ b/pci/asihpi/hpi6000.c
@@ -582,6 +582,9 @@ static short create_adapter_obj(struct hpi_adapter_obj *pao,
 		pao->adapter_type, pao->index);
 	pao->open = 0;	/* upon creation the adapter is closed */
 
+	if (phw->p_cache)
+		phw->p_cache->adap_idx = pao->index;
+
 	return hpi_add_adapter(pao);
 }
 
diff --git a/pci/asihpi/hpi6205.c b/pci/asihpi/hpi6205.c
index b740edc..5ebf8f8 100644
--- a/pci/asihpi/hpi6205.c
+++ b/pci/asihpi/hpi6205.c
@@ -718,6 +718,9 @@ static u16 create_adapter_obj(struct hpi_adapter_obj *pao,
 
 	pao->open = 0;	/* upon creation the adapter is closed */
 
+	if (phw->p_cache)
+		phw->p_cache->adap_idx = pao->index;
+
 	HPI_DEBUG_LOG(INFO, "bootload DSP OK\n");
 
 	return hpi_add_adapter(pao);
diff --git a/pci/asihpi/hpicmn.c b/pci/asihpi/hpicmn.c
index 793236e..85c2972 100644
--- a/pci/asihpi/hpicmn.c
+++ b/pci/asihpi/hpicmn.c
@@ -197,11 +197,18 @@ static unsigned int control_cache_alloc_check(struct hpi_control_cache *pC)
 				&p_master_cache[byte_count];
 
 			if (!info->size_in32bit_words) {
+				if (i == 0) {
+					HPI_DEBUG_LOG(INFO,
+						"adap %d cache not ready?\n",
+						pC->adap_idx);
+					return 0;
+				}
 				/* ? This is a severe error, the cache is probably
 				   corrupted.  Minimum valid entry size is
 				   sizeof(struct hpi_control_cache_info) */
 				HPI_DEBUG_LOG(ERROR,
-					"zero size cache entry %d\n", i);
+					"adap %d zero size cache entry %d\n",
+					pC->adap_idx, i);
 				break;
 			}
 
@@ -231,12 +238,13 @@ static unsigned int control_cache_alloc_check(struct hpi_control_cache *pC)
 
 		if (byte_count != pC->cache_size_in_bytes)
 			HPI_DEBUG_LOG(WARNING,
-				"bytecount %d != cache size %d", byte_count,
+				"adap %d bytecount %d != cache size %d",
+				pC->adap_idx, byte_count,
 				pC->cache_size_in_bytes);
 		else
 			HPI_DEBUG_LOG(DEBUG,
-				"cache good. bytecount == cache size = %d",
-				byte_count);
+				"adap %d cache good, bytecount == cache size = %d",
+				pC->adap_idx, byte_count);
 
 		pC->init = cached;
 	}
diff --git a/pci/asihpi/hpicmn.h b/pci/asihpi/hpicmn.h
index e2f6f1f..2708c4d 100644
--- a/pci/asihpi/hpicmn.h
+++ b/pci/asihpi/hpicmn.h
@@ -33,8 +33,9 @@ struct hpi_adapter_obj {
 };
 
 struct hpi_control_cache {
-	u32 init;	     /**< indicates whether the
+	u16 init;	     /**< indicates whether the
 				structures are initialized */
+	u16 adap_idx;
 	u32 control_count;
 	u32 cache_size_in_bytes;
 	struct hpi_control_cache_info
-- 
1.7.0.4

  parent reply	other threads:[~2011-02-10  4:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-10  4:25 [PATCH] asihpi: Update from 4.04 to 4.06 linux
2011-02-10  4:25 ` [PATCH 01/28] Switch to dev_printk linux
2011-02-10  4:25 ` [PATCH 02/28] Poison adapter_index in message. Remove unused function linux
2011-02-10  4:25 ` [PATCH 03/28] Simplify debug logging linux
2011-02-10  4:25 ` [PATCH 04/28] HPI 4.05.14 linux
2011-02-10  4:25 ` [PATCH 06/28] Rewrite PCM timer function. Update control names linux
2011-02-10  4:26 ` linux [this message]
2011-02-10  4:26 ` [PATCH 08/28] Add include guard linux
2011-02-10  4:26 ` [PATCH 09/28] Checkpatch line lengths etc linux
2011-02-10  4:26 ` [PATCH 10/28] Update error codes linux
2011-02-10  4:26 ` [PATCH 12/28] Reduce number of error codes returned to upper layers linux
2011-02-10  4:26 ` [PATCH 13/28] Code cleanup linux
2011-02-10  4:26 ` [PATCH 14/28] Remove int flag polling code preparing for stream interrupts linux
2011-02-10  4:26 ` [PATCH 15/28] Cosmetic + a minor comments linux
2011-02-10  4:26 ` [PATCH 16/28] Replace adapter list with single item in subsys response linux
2011-02-10  4:26 ` [PATCH 17/28] Add snd_card_set_dev to init linux
2011-02-10  4:26 ` [PATCH 18/28] Add volume mute control linux
2011-02-10  4:26 ` [PATCH 19/28] Allow adapters with duplicate index jumpers to be discovered linux
2011-02-10  4:26 ` [PATCH 20/28] Clarify firmware id selection linux
2011-02-10  4:26 ` [PATCH 21/28] Remove unused code and data linux
2011-02-10  4:26 ` [PATCH 22/28] Use consistent err return variable, change some bad variable names linux
2011-02-10  4:26 ` [PATCH 23/28] New functions prep for interrupt driven streams linux
2011-02-10  4:26 ` [PATCH 24/28] Minor define updates linux
2011-02-10  4:26 ` [PATCH 25/28] Ensure all adapter data is cleared on device removal linux
2011-02-10  4:26 ` [PATCH 26/28] Tighten firmware version requirements linux
2011-02-10  4:26 ` [PATCH 27/28] Fix outstream start trigger for non-mmap adapters linux
2011-02-10  4:26 ` [PATCH 28/28] HPI v4.06 linux
2011-02-10 17:52 ` [PATCH] asihpi: Update from 4.04 to 4.06 Takashi Iwai
2011-02-10 23:19   ` Eliot Blennerhassett
     [not found]   ` <4D54488D.5030803@audioscience.com>
2011-02-11  6:23     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297311981-30448-8-git-send-email-linux@audioscience.com \
    --to=linux@audioscience.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=eblennerhassett@audioscience.com \
    --cc=patch@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.