From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH] ASoC: Warn if WM8903 platform data is used to enable microphone IRQ Date: Sun, 13 Feb 2011 16:19:23 +0000 Message-ID: <1297613963.3436.20.camel@odin> References: <1297435289-13587-1-git-send-email-broonie@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f51.google.com (mail-ww0-f51.google.com [74.125.82.51]) by alsa0.perex.cz (Postfix) with ESMTP id 19AF91037EA for ; Sun, 13 Feb 2011 17:19:28 +0100 (CET) Received: by wwe15 with SMTP id 15so4004463wwe.20 for ; Sun, 13 Feb 2011 08:19:27 -0800 (PST) In-Reply-To: <1297435289-13587-1-git-send-email-broonie@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com List-Id: alsa-devel@alsa-project.org On Fri, 2011-02-11 at 14:41 +0000, Mark Brown wrote: > The WM8903 interrupts are clear on read so if the WM8903 detection is > enabled from platform data when the IRQ is in use (rather than using a > direct signal from a GPIO) status may be lost during startup. Help users > spot this misconfiguration by adding a WARN_ON(). > > Signed-off-by: Mark Brown > --- > sound/soc/codecs/wm8903.c | 22 ++++++++++++++++++++++ > 1 files changed, 22 insertions(+), 0 deletions(-) Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk