From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/3] ASoC: omap: rx51: Use gpio_request_one to configure tvout_sel gpio
Date: Tue, 15 Feb 2011 21:54:41 +0000 [thread overview]
Message-ID: <1297806881.3337.90.camel@odin> (raw)
In-Reply-To: <1297696822-32174-1-git-send-email-jhnikula@gmail.com>
On Mon, 2011-02-14 at 17:20 +0200, Jarkko Nikula wrote:
> Just slight cleanup to be sync with upcoming change.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> ---
> sound/soc/omap/rx51.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/omap/rx51.c b/sound/soc/omap/rx51.c
> index 2d7d411..9411969 100644
> --- a/sound/soc/omap/rx51.c
> +++ b/sound/soc/omap/rx51.c
> @@ -394,10 +394,10 @@ static int __init rx51_soc_init(void)
> if (!machine_is_nokia_rx51())
> return -ENODEV;
>
> - err = gpio_request(RX51_TVOUT_SEL_GPIO, "tvout_sel");
> + err = gpio_request_one(RX51_TVOUT_SEL_GPIO,
> + GPIOF_DIR_OUT | GPIOF_INIT_LOW, "tvout_sel");
> if (err)
> goto err_gpio_tvout_sel;
> - gpio_direction_output(RX51_TVOUT_SEL_GPIO, 0);
>
> rx51_snd_device = platform_device_alloc("soc-audio", -1);
> if (!rx51_snd_device) {
All applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2011-02-15 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 15:20 [PATCH 1/3] ASoC: omap: rx51: Use gpio_request_one to configure tvout_sel gpio Jarkko Nikula
2011-02-14 15:20 ` [PATCH 2/3] ASoC: omap: rx51: Add headset support Jarkko Nikula
2011-02-14 15:20 ` [PATCH 3/3] ASoC: omap: rx51: Report headset insertion instead of video out cable Jarkko Nikula
2011-02-14 15:58 ` [PATCH 1/3] ASoC: omap: rx51: Use gpio_request_one to configure tvout_sel gpio Mark Brown
2011-02-15 21:54 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297806881.3337.90.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jhnikula@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.