From: Peter Zijlstra <peterz@infradead.org>
To: Venkatesh Pallipadi <venki@google.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Paul Turner <pjt@google.com>,
Mike Galbraith <efault@gmx.de>, Nick Piggin <npiggin@gmail.com>,
Tim Chen <tim.c.chen@intel.com>, Alex Shi <alex.shi@intel.com>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Subject: Re: [PATCH] sched: Wholesale removal of sd_idle logic
Date: Wed, 16 Feb 2011 12:43:55 +0100 [thread overview]
Message-ID: <1297856635.2413.130.camel@twins> (raw)
In-Reply-To: <1297723130-693-1-git-send-email-venki@google.com>
On Mon, 2011-02-14 at 14:38 -0800, Venkatesh Pallipadi wrote:
>
> The initial patch here - https://patchwork.kernel.org/patch/532501/
> applies cleanly over the below change and provides a micro-optimization
> for a specific case, where an idle core can pull tasks instead of a
> core with one thread being idle and other thread being busy.
> It will be good to get some data on whether this micro-optimization
> matters or not.
I would much rather see a solution that solves that problem for the more
generic situation where we lower capacity to 1.
The whole double-balance thing is fairly inherent in the whole design,
and making an exception for just one special case doesn't look right.
next prev parent reply other threads:[~2011-02-16 11:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 20:51 [PATCH] sched: Resolve sd_idle and first_idle_cpu Catch-22 Venkatesh Pallipadi
2011-02-04 21:25 ` [PATCH] sched: Resolve sd_idle and first_idle_cpu Catch-22 - v1 Venkatesh Pallipadi
2011-02-07 13:50 ` Peter Zijlstra
2011-02-07 18:21 ` Venkatesh Pallipadi
2011-02-07 19:53 ` Suresh Siddha
2011-02-08 17:37 ` Venkatesh Pallipadi
2011-02-08 18:13 ` Misc sd_idle related fixes Venkatesh Pallipadi
2011-02-09 9:29 ` Peter Zijlstra
2011-02-10 17:24 ` Venkatesh Pallipadi
2011-02-08 18:13 ` [PATCH 1/3] sched: Resolve sd_idle and first_idle_cpu Catch-22 Venkatesh Pallipadi
2011-02-08 18:13 ` [PATCH 2/3] sched: fix_up broken SMT load balance dilation Venkatesh Pallipadi
2011-02-08 18:13 ` [PATCH 3/3] sched: newidle balance set idle_timestamp only on successful pull Venkatesh Pallipadi
2011-02-09 3:37 ` Mike Galbraith
2011-02-09 15:55 ` [PATCH] sched: Resolve sd_idle and first_idle_cpu Catch-22 - v1 Peter Zijlstra
2011-02-12 1:20 ` Suresh Siddha
2011-02-14 22:38 ` [PATCH] sched: Wholesale removal of sd_idle logic Venkatesh Pallipadi
2011-02-15 17:01 ` Vaidyanathan Srinivasan
2011-02-15 18:26 ` Venkatesh Pallipadi
2011-02-16 8:53 ` Vaidyanathan Srinivasan
2011-02-16 11:43 ` Peter Zijlstra [this message]
2011-02-16 13:50 ` [tip:sched/core] " tip-bot for Venkatesh Pallipadi
2011-02-15 9:15 ` [PATCH] sched: Resolve sd_idle and first_idle_cpu Catch-22 - v1 Peter Zijlstra
2011-02-15 19:11 ` Suresh Siddha
2011-02-18 1:05 ` Alex,Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297856635.2413.130.camel@twins \
--to=peterz@infradead.org \
--cc=alex.shi@intel.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@gmail.com \
--cc=pjt@google.com \
--cc=suresh.b.siddha@intel.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=tim.c.chen@intel.com \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.