From: Artem Bityutskiy <dedekind1@gmail.com>
To: Jarkko Lavinen <jarkko.lavinen@nokia.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 3/3] mtd: Add mtdswap block driver
Date: Fri, 18 Feb 2011 16:14:30 +0200 [thread overview]
Message-ID: <1298038470.5623.50.camel@localhost> (raw)
In-Reply-To: <1297692971-7399-4-git-send-email-jarkko.lavinen@nokia.com>
On Mon, 2011-02-14 at 16:16 +0200, Jarkko Lavinen wrote:
> +config MTD_SWAP_STRICT
> + bool "Strict erase error handling"
> + depends on MTD_SWAP
> + help
> + Enables strict tolerance on failed erasures, marking erase blocks bad
> + right after the first failed operation. With non-strict mode the
> + erase operation is retried.
This is too small thing to deserve a separate config option. And the
help text does not explain what for is this needed, what's the problem
with re-trying the erase operation - it looks like over-design.
Is it please possible to remove this config option?
Otherwise I'm fine with the patches, thanks! I'm putting them to my l2
tree but I wait an updated version from you without this option. In the
worst case, if you can prove the need for this option, make it a module
parameter instead please.
Thanks a lot! This is good stuff and I know it works.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-02-18 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 14:16 Jarkko Lavinen
2011-02-14 14:16 ` [PATCH 1/3] mtd_blkdevs: Add background processing support Jarkko Lavinen
2011-02-14 14:16 ` [PATCH 2/3] mtd_blkdevs: Set the maximum discards size Jarkko Lavinen
2011-02-14 14:16 ` [PATCH 3/3] mtd: Add mtdswap block driver Jarkko Lavinen
2011-02-18 14:14 ` Artem Bityutskiy [this message]
2011-02-22 16:21 ` Jarkko Lavinen
2011-02-25 11:03 ` Artem Bityutskiy
2011-03-09 8:08 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298038470.5623.50.camel@localhost \
--to=dedekind1@gmail.com \
--cc=jarkko.lavinen@nokia.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.