From: Alex Elder <aelder@sgi.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: Don't ever try to set the device blocksize in repair
Date: Tue, 22 Feb 2011 14:04:19 -0600 [thread overview]
Message-ID: <1298405059.1960.41.camel@doink> (raw)
In-Reply-To: <4D62B7D1.4040901@redhat.com>
On Mon, 2011-02-21 at 13:06 -0600, Eric Sandeen wrote:
> On 4k devices, we get this warning from repair:
>
> # xfs_repair /dev/sdc2
> xfs_repair: warning - cannot set blocksize 512 on block device /dev/sdc2: Invalid argument
> Phase 1 - find and verify superblock...
> ...
>
> but things proceed without trouble after that.
>
> I'm unable to find any history or reason for setting the
> device blocksize at the beginning of repair, and in any case,
> things clearly work without doing so. So, let's just remove it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
On Linux anyway, the way it's used here is pretty
pointless anyway. It passes either 0 or 1, which
means either don't set it (if "living dangerously")
or do set it, to the minimum XFS sector size, 512
bytes. Hence it'll screw up on > 512-byte sector
devices.
If there was a reason for setting it, it should
do so by setting it to the device's logical block
size rather than assuming 512.
But I don't see a reason to set it either, so the
change looks good to me.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-02-22 20:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 19:06 [PATCH] xfsprogs: Don't ever try to set the device blocksize in repair Eric Sandeen
2011-02-22 20:04 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298405059.1960.41.camel@doink \
--to=aelder@sgi.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.