All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lin Ming <ming.m.lin@intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>,
	Stephane Eranian <eranian@google.com>,
	Andi Kleen <andi@firstfloor.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 1/6] perf-events: Add support for supplementary event registers v5
Date: Wed, 23 Feb 2011 09:09:08 +0800	[thread overview]
Message-ID: <1298423348.2835.3.camel@minggr.sh.intel.com> (raw)
In-Reply-To: <1298388053.2217.204.camel@twins>

On Tue, 2011-02-22 at 23:20 +0800, Peter Zijlstra wrote:
> On Mon, 2011-02-21 at 00:56 +0800, Lin Ming wrote:
> > @@ -225,7 +225,10 @@ struct perf_event_attr {
> >         };
> >  
> >         __u32                   bp_type;
> > -       __u64                   bp_addr;
> > +       union {
> > +               __u64           bp_addr;
> > +               __u64           event_extra; /* Extra for some events */
> > +       };
> >         __u64                   bp_len;
> >  }; 
> 
> I did s/event_extra/config1/g and:
> 
> Index: linux-2.6/include/linux/perf_event.h
> ===================================================================
> --- linux-2.6.orig/include/linux/perf_event.h
> +++ linux-2.6/include/linux/perf_event.h
> @@ -227,9 +230,12 @@ struct perf_event_attr {
>  	__u32			bp_type;
>  	union {
>  		__u64		bp_addr;
> -		__u64		config1; /* Extra for some events */
> +		__u64		config1;	/* extension of config0 */
> +	};
> +	union {
> +		__u64		bp_len;
> +		__u64		config2;	/* extension of config1 */
>  	};
> -	__u64			bp_len;
>  };
>  
>  /*
> 
> Giving us basically 192 bits of config{,1,2} space and the possibility
> of eventually deprecating the bp_ stuff.

OK, 

Do you mean it's possible to encode bp_type/bp_addr/bp_len into
config1/config2?



  reply	other threads:[~2011-02-23  1:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-20 16:56 [PATCH 1/6] perf-events: Add support for supplementary event registers v5 Lin Ming
2011-02-22 15:20 ` Peter Zijlstra
2011-02-23  1:09   ` Lin Ming [this message]
2011-02-23  1:12 ` Stephane Eranian
2011-02-23  2:42   ` Lin Ming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298423348.2835.3.camel@minggr.sh.intel.com \
    --to=ming.m.lin@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.