All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Hank Janssen <hjanssen@microsoft.com>
Cc: devel@linuxdriverproject.org, gregkh@suse.de,
	linux-kernel@vger.kernel.org, virtualization@lists.osdl.org
Subject: Re: [PATCH 1/6] Staging: hv: vmbus_drv.c Replaced DPRINT with native pr_XXX
Date: Tue, 22 Feb 2011 20:51:25 -0800	[thread overview]
Message-ID: <1298436685.26511.381.camel@Joe-Laptop> (raw)
In-Reply-To: <1298417565-12356-1-git-send-email-hjanssen@microsoft.com>

On Tue, 2011-02-22 at 15:32 -0800, Hank Janssen wrote:
> This group of patches removes all DPRINT from hv_vmbus.ko.
> It is divided in several patches due to size.
[]
> -		DPRINT_ERR(VMBUS_DRV,
> -			   "ERROR - Unable to register vmbus root device");
> +		pr_err("%s: %s ERROR Unable to register vmbus root device",
> +		       VMBUS_MOD, __func__);

All of the pr_<level> calls should probably have a terminating "\n"

Also, ff all the pr_<level>'s are using VMBUS_MOD,
then perhaps it would look better to add

#define pr_fmt(fmt) "%s: " fmt, VMBUS_MOD
or
#define pr_fmt(fmt) "%s:%s " fmt, VMBUS_MOD, __func__
(if you must)

and then use:

	pr_err("ERROR Unable to register vmbus root device\n");

  parent reply	other threads:[~2011-02-23  4:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22 23:32 [PATCH 1/6] Staging: hv: vmbus_drv.c Replaced DPRINT with native pr_XXX Hank Janssen
2011-02-22 23:32 ` [PATCH 2/6] Staging: hv: hv.c Removed all DPRINT and debug - using pr_err now Hank Janssen
2011-02-22 23:32   ` [PATCH 3/6] Staging: hv: channel.c Removed debug DPRINTS use pr_err for errors Hank Janssen
2011-02-22 23:32     ` [PATCH 4/6] Staging: hv: channel_mgmt.c Removed DPRINT and implemented pr_XX Hank Janssen
2011-02-22 23:32       ` [PATCH 5/6] Staging: hv: ring_buffer.c Removed DPRINT replaced with pr_XX Hank Janssen
2011-02-22 23:32         ` [PATCH 6/6] Staging: hv: connection.c " Hank Janssen
2011-02-23 19:15   ` [PATCH 2/6] Staging: hv: hv.c Removed all DPRINT and debug - using pr_err now Greg KH
2011-02-23 19:41     ` Hank Janssen
2011-02-23 21:56       ` Greg KH
2011-02-23 23:17         ` Hank Janssen
2011-02-23 23:48           ` Greg KH
2011-02-24  0:57           ` Joe Perches
2011-02-24  1:29             ` Greg KH
2011-02-23  4:51 ` Joe Perches [this message]
2011-02-23 16:58   ` [PATCH 1/6] Staging: hv: vmbus_drv.c Replaced DPRINT with native pr_XXX Hank Janssen
2011-02-23 17:09     ` Joe Perches
2011-02-23 17:53       ` Hank Janssen
2011-02-23 17:10     ` Dan Carpenter
2011-02-23 19:11 ` Greg KH
2011-02-23 20:20   ` Hank Janssen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298436685.26511.381.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@suse.de \
    --cc=hjanssen@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.