All of lore.kernel.org
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@gnu.org>
To: Greg KH <gregkh@suse.de>
Cc: Greg KH <greg@kroah.com>,
	Michal Nazarewicz <m.nazarewicz@samsung.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/2] USB: ffs-test: fix header path
Date: Sun, 27 Feb 2011 04:58:48 -0300	[thread overview]
Message-ID: <1298793528.2284.2.camel@offworld> (raw)
In-Reply-To: <20110217190554.GA25833@suse.de>

On Thu, 2011-02-17 at 11:05 -0800, Greg KH wrote:
> On Thu, Feb 17, 2011 at 03:57:32PM -0300, Davidlohr Bueso wrote:
> > On Thu, 2011-02-17 at 10:42 -0800, Greg KH wrote:
> > > On Sun, Feb 06, 2011 at 02:13:33PM -0300, Davidlohr Bueso wrote:
> > > > From: Davidlohr Bueso <dave@gnu.org>
> > > > 
> > > > When compiling this program the functionfs.h header cannot be found, producing:
> > > > ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory
> > > > 
> > > > This patch also fixes the following warning:
> > > > ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’
> > > > 
> > > > Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> > > > ---
> > > >  tools/usb/ffs-test.c |    4 ++--
> > > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > This patch doesn't apply properly to the linux-next branch, what did you
> > > make it against?
> > > 
> > 
> > It was against Linus' tree (did a pull right before submitting the
> > patch).
> 
> Ah, so you think this is needed for Linus's tree now?  Care to resend it
> and I'll queue it up to the proper tree, sorry, I missed that.
> 
Sorry about the delay, you wouldn't believe the problems I have with a
slow ('90s) internet connection when trying to clone a tree. Here is a
version against the latest linux-next. Thanks.

From: Davidlohr Bueso <dave@gnu.org>
Date: Sun, 27 Feb 2011 04:55:59 -0300
Subject: [PATCH] USB: ffs-test: fix header path

When compiling this program the functionfs.h header cannot be found, producing:
ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory

This patch also fixes the following warning:
ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’

Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
 tools/usb/ffs-test.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/usb/ffs-test.c b/tools/usb/ffs-test.c
index bbe2e3a..b9c7986 100644
--- a/tools/usb/ffs-test.c
+++ b/tools/usb/ffs-test.c
@@ -37,7 +37,7 @@
 #include <sys/types.h>
 #include <unistd.h>
 
-#include <linux/usb/functionfs.h>
+#include "../../include/linux/usb/functionfs.h"
 
 
 /******************** Little Endian Handling ********************************/
@@ -450,7 +450,7 @@ invalid:
 		    len, expected, *p);
 		for (p = buf, len = 0; len < nbytes; ++p, ++len) {
 			if (0 == (len % 32))
-				fprintf(stderr, "%4d:", len);
+				fprintf(stderr, "%4zd:", len);
 			fprintf(stderr, " %02x", *p);
 			if (31 == (len % 32))
 				fprintf(stderr, "\n");
-- 
1.7.1




      reply	other threads:[~2011-02-27  9:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-06 17:13 [PATCH v2 1/2] USB: ffs-test: fix header path Davidlohr Bueso
2011-02-16 13:38 ` Davidlohr Bueso
2011-02-17 18:42 ` Greg KH
2011-02-17 18:57   ` Davidlohr Bueso
2011-02-17 19:05     ` Greg KH
2011-02-27  7:58       ` Davidlohr Bueso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298793528.2284.2.camel@offworld \
    --to=dave@gnu.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.nazarewicz@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.