From: Mike Galbraith <efault@gmx.de>
To: Rik van Riel <riel@redhat.com>
Cc: Venkatesh Pallipadi <venki@google.com>,
mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
a.p.zijlstra@chello.nl, mtosatti@redhat.com, tglx@linutronix.de,
mingo@elte.hu
Subject: Re: [tip:sched/core] sched: Add yield_to(task, preempt) functionality
Date: Mon, 28 Feb 2011 10:26:29 +0100 [thread overview]
Message-ID: <1298885189.9501.2.camel@marge.simson.net> (raw)
In-Reply-To: <4D689346.1090002@redhat.com>
On Sat, 2011-02-26 at 00:44 -0500, Rik van Riel wrote:
> On 02/25/2011 07:43 PM, Venkatesh Pallipadi wrote:
> > The below comment says about rescheduling p's CPU. But the rq variable
> > we have here is the curr_rq and not p_rq. So, should this be done in
> > yield_to() with p_rq. I did try to see the discussion on other
> > versions of this patch. v3 and before had -
> > "resched_task(task_of(p_cfs_rq->curr));" which seems to be correct...
>
> You are correct. We are calling resched_task on the wrong task,
> we should call it on p's runqueue's current task...
Are you going to send a fix?
> >> +
> >> + /* Make p's CPU reschedule; pick_next_entity takes care of fairness. */
> >> + if (preempt)
> >> + resched_task(rq->curr);
next prev parent reply other threads:[~2011-02-28 9:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 14:44 [PATCH -v8a 0/7] directed yield for Pause Loop Exiting Rik van Riel
2011-02-01 14:47 ` [PATCH -v8a 1/7] sched: check the right ->nr_running in yield_task_fair Rik van Riel
2011-02-03 14:11 ` [tip:sched/core] sched: Check the right ->nr_running in yield_task_fair() tip-bot for Rik van Riel
2011-02-01 14:48 ` [PATCH -v8a 2/7] sched: limit the scope of clear_buddies Rik van Riel
2011-02-03 14:11 ` [tip:sched/core] sched: Limit " tip-bot for Rik van Riel
2011-02-01 14:50 ` [PATCH -v8a 4/7] sched: Add yield_to(task, preempt) functionality Rik van Riel
2011-02-01 15:52 ` Peter Zijlstra
2011-02-03 12:58 ` Peter Zijlstra
2011-02-03 14:12 ` [tip:sched/core] " tip-bot for Mike Galbraith
2011-02-26 0:43 ` Venkatesh Pallipadi
2011-02-26 5:44 ` Rik van Riel
2011-02-28 9:26 ` Mike Galbraith [this message]
2011-03-02 0:28 ` [PATCH] sched: resched proper CPU on yield_to Venkatesh Pallipadi
2011-03-02 3:33 ` Rik van Riel
2011-03-02 3:37 ` Venkatesh Pallipadi
2011-03-02 3:52 ` Rik van Riel
2011-03-04 11:50 ` [tip:sched/core] sched: Resched proper CPU on yield_to() tip-bot for Venkatesh Pallipadi
2011-02-01 14:51 ` [PATCH -v8a 3/7] sched: use a buddy to implement yield_task_fair Rik van Riel
2011-02-01 15:53 ` Peter Zijlstra
2011-02-03 12:58 ` Peter Zijlstra
2011-02-03 14:12 ` [tip:sched/core] sched: Use a buddy to implement yield_task_fair() tip-bot for Rik van Riel
2011-02-01 14:51 ` [PATCH -v8a 5/7] export pid symbols needed for kvm_vcpu_on_spin Rik van Riel
2011-02-01 14:52 ` [PATCH -v8a 6/7] kvm: keep track of which task is running a KVM vcpu Rik van Riel
2011-02-01 14:53 ` [PATCH -v8a 7/7] kvm: use yield_to instead of sleep in kvm_vcpu_on_spin Rik van Riel
2011-02-07 9:08 ` [PATCH -v8a 0/7] directed yield for Pause Loop Exiting Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298885189.9501.2.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.