From: Michael Buesch <mb@bu3sch.de>
To: Chris Ball <cjb@laptop.org>
Cc: linux-omap <linux-omap@vger.kernel.org>,
linux-mmc@vger.kernel.org, Tony Lindgren <tony@atomide.com>
Subject: [PATCH] omap-mmc: Fix possible NULL pointer deref
Date: Wed, 02 Mar 2011 19:18:23 +0100 [thread overview]
Message-ID: <1299089903.13604.19.camel@marge> (raw)
Either OMAP_MMC_STAT_CARD_ERR or OMAP_MMC_STAT_END_OF_CMD might
fire if there is no host->cmd pointer.
Check for a valid host->cmd pointer before calling mmc_omap_cmd_done().
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Acked-by: Tony Lindgren <tony@atomide.com>
---
Fixes
[ 3.814483] Unable to handle kernel NULL pointer dereference at virtual address 00000018
...
[ 3.841247] CPU: 0 Not tainted (2.6.38-rc6 #5)
[ 3.846374] PC is at mmc_omap_cmd_done+0x1c/0x154
[ 3.851379] LR is at mmc_omap_cmd_done+0x1c/0x154
...
[ 4.140014] [<c0234af0>] (mmc_omap_cmd_done+0x1c/0x154) from [<c0234ea4>] (mmc_omap_irq+0x27c/0x32c)
[ 4.149749] [<c0234ea4>] (mmc_omap_irq+0x27c/0x32c) from [<c008645c>] (handle_IRQ_event+0x24/0xe4)
[ 4.159332] [<c008645c>] (handle_IRQ_event+0x24/0xe4) from [<c0087dac>] (handle_level_irq+0xbc/0x13c)
[ 4.169158] [<c0087dac>] (handle_level_irq+0xbc/0x13c) from [<c002b070>] (asm_do_IRQ+0x70/0x94)
[ 4.178466] [<c002b070>] (asm_do_IRQ+0x70/0x94) from [<c003016c>] (__irq_svc+0x4c/0xb8)
Index: linux-omap-2.6/drivers/mmc/host/omap.c
===================================================================
--- linux-omap-2.6.orig/drivers/mmc/host/omap.c 2011-02-27 12:32:03.051061690 +0100
+++ linux-omap-2.6/drivers/mmc/host/omap.c 2011-02-27 12:32:27.622530875 +0100
@@ -832,7 +832,7 @@
return IRQ_HANDLED;
}
- if (end_command)
+ if (end_command && host->cmd)
mmc_omap_cmd_done(host, host->cmd);
if (host->data != NULL) {
if (transfer_error)
next reply other threads:[~2011-03-02 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 18:18 Michael Buesch [this message]
2011-04-11 21:02 ` [PATCH] omap-mmc: Fix possible NULL pointer deref Chris Ball
-- strict thread matches above, loose matches on Subject: below --
2011-02-27 11:38 Michael Buesch
2011-03-02 18:14 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299089903.13604.19.camel@marge \
--to=mb@bu3sch.de \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.