All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3 5/5] iwlwifi: move remaining iwl-agn-rx.c code into iwl-rx.c
Date: Wed, 02 Mar 2011 12:00:09 -0800	[thread overview]
Message-ID: <1299096009.5082.127.camel@wwguy-huron> (raw)
In-Reply-To: <1298899997-2372-5-git-send-email-sgruszka@redhat.com>

Hi Stanislaw,

On Mon, 2011-02-28 at 05:33 -0800, Stanislaw Gruszka wrote:
> There is no need to have separate iwl-agn-rx.c file after iwlegacy
> split.
> 
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
>  drivers/net/wireless/iwlwifi/Makefile     |    2 +-
>  drivers/net/wireless/iwlwifi/iwl-agn-rx.c |  264 -----------------------------
>  drivers/net/wireless/iwlwifi/iwl-core.h   |    2 -
>  drivers/net/wireless/iwlwifi/iwl-rx.c     |  226 ++++++++++++++++++++++++-
>  4 files changed, 225 insertions(+), 269 deletions(-)
>  delete mode 100644 drivers/net/wireless/iwlwifi/iwl-agn-rx.c
> 
I got the following warning:

drivers/net/wireless/iwlwifi/iwl-rx.c:506:6: warning: symbol
'iwl_rx_statistics' was not declared. Should it be static?
drivers/net/wireless/iwlwifi/iwl-rx.c:575:6: warning: symbol
'iwl_reply_statistics' was not declared. Should it be static?
drivers/net/wireless/iwlwifi/iwl-rx.c:600:6: warning: symbol
'iwl_rx_missed_beacon_notif' was not declared. Should it be static?


when I compile with sparse

Thanks
Wey


  parent reply	other threads:[~2011-03-02 20:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-28 13:33 [PATCH v3 1/5] iwlwifi: fix dma mappings and skbs leak Stanislaw Gruszka
2011-02-28 13:33 ` [PATCH v3 2/5] iwlegacy: " Stanislaw Gruszka
2011-02-28 15:16   ` Guy, Wey-Yi
2011-02-28 13:33 ` [PATCH v3 3/5] iwlwifi: add {ack,plpc}_check module parameters Stanislaw Gruszka
2011-02-28 15:17   ` Guy, Wey-Yi
2011-02-28 13:33 ` [PATCH v3 4/5] iwlwifi: move check health code into iwl-rx.c Stanislaw Gruszka
2011-02-28 15:18   ` Guy, Wey-Yi
2011-02-28 13:33 ` [PATCH v3 5/5] iwlwifi: move remaining iwl-agn-rx.c " Stanislaw Gruszka
2011-02-28 15:19   ` Guy, Wey-Yi
2011-03-02 20:00   ` Guy, Wey-Yi [this message]
2011-03-03  9:19     ` Stanislaw Gruszka
2011-03-03 15:19       ` Guy, Wey-Yi
2011-03-03 15:44         ` Stanislaw Gruszka
2011-02-28 15:15 ` [PATCH v3 1/5] iwlwifi: fix dma mappings and skbs leak Guy, Wey-Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299096009.5082.127.camel@wwguy-huron \
    --to=wey-yi.w.guy@intel.com \
    --cc=ilw@linux.intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.