From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Date: Thu, 03 Mar 2011 20:48:15 +0000 Subject: Re: [lm-sensors] [Nouveau] hwmon API update Message-Id: <1299185295.2255.13.camel@workstation> List-Id: References: <4D57CC24.1040306@free.fr> <20110213171640.GB13323@ericsson.com> <20110213230833.0ee2ff16@endymion.delvare> <20110303152216.GA21667@ericsson.com> <4D6FCFF2.7040604@free.fr> In-Reply-To: <4D6FCFF2.7040604-GANU6spQydw@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Martin Peres Cc: Jean Delvare , nouveau , "lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org" , Guenter Roeck Am Donnerstag, den 03.03.2011, 18:29 +0100 schrieb Martin Peres: > Le 03/03/2011 16:22, Guenter Roeck a =C3=A9crit : > > On Thu, Mar 03, 2011 at 04:36:09AM -0500, Dave Airlie wrote: > >> On Mon, Feb 14, 2011 at 8:08 AM, Jean Delvare wro= te: > >>> On Sun, 13 Feb 2011 09:16:40 -0800, Guenter Roeck wrote: > >>>> On Sun, Feb 13, 2011 at 07:18:44AM -0500, Martin Peres wrote: > >>>>> Hi, > >>>>> > >>>>> I am working on power management on the nouveau driver and I need a= way > >>>>> to get data out of and send commands to the i2c drivers from the ke= rnel > >>>>> space. > >> Martin, > >> > >> you probably should have cc'ed Matthew since it was his patch you base= d this on, > >> and I think he can provide a good explaination. > >> > >> to clarify some points, > >> > >> radeon does probably want something exactly like this, we just haven't= gotten to > >> it completely yet, I'd rather not have two drivers in the kernel for > >> exact same hardware, > >> and I believe sharing the hwmon code to do what we want is a good plan= since you > >> don't go around reinventing wheels, but if hwmon/i2c maintainers have > >> no interest > >> it leaves with little choice but to implement about 5-10 i2c drivers > >> again in drm codebase. > >> > >> Maybe hwmon/i2c maintainers could suggest a cleaner way to implement > >> what we want, > >> which I think I can summarize as > >> > >> a) access to monitored values in-kernel > >> b) no userspace access to the same values except via sanitised via the= driver. > >> > > This is not a matter of "no interest". Interest is there, but if one de= mands > > too much one may get nothing. > > > > Request for b) so far was "no userspace access", period. This is unacce= ptable > > since providing userspace access to monitored values is the whole point= of hwmon. And that is what we want to do. But it would be nice if the graphics drivers could provide a _single_ interface to userspace. Not all boards have i2c hardware monitoring chips and with a single interface we could fall back to the internal gpu sensor, transparently for the user. > > > > I could imagine an API that covers both a) and b), as long as b) focuses > > on the "sanitize" aspect and doesn't try to limit userspace access to a= ttributes. > > > > Guenter > b) was introduced by Dave, I never asked for it because I don't mind=20 > duplicating sensor data (one hwmon device named nouveau and one for the=20 > raw access to the i2c chip). Sorry for the confusion Martin, I brought up the point of limiting userspace access and did not cc the nouveau mailing list. I think it is bad behaviour to expose values to userspace which are totally off the real values. This confuses users and should be avoided, especially since we can provide sanitized values. Why should we push the logic and api for sanitizing the values to many hwmon drivers if we could easily do this at a single point in the graphics driver, if we provide the userspace interface ourself and use the hwmon driver only to instrument the monitoring chip? > My only wish was to provide a simple way for users to read/change their=20 > fan speed and get the GPU temperature no matter if their card have an=20 > i2c controller or not. > I do agree that sanitizing could be of interest, I especially think=20 > about tweaking the temperature value with parameters stored inside the=20 > vbios. >=20 > I am fully open to suggestions as long as it involves sharing the code=20 > in one way or another. >=20 > Martin > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/nouveau >=20 _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Subject: Re: [lm-sensors] hwmon API update Date: Thu, 03 Mar 2011 21:48:15 +0100 Message-ID: <1299185295.2255.13.camel@workstation> References: <4D57CC24.1040306@free.fr> <20110213171640.GB13323@ericsson.com> <20110213230833.0ee2ff16@endymion.delvare> <20110303152216.GA21667@ericsson.com> <4D6FCFF2.7040604@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4D6FCFF2.7040604-GANU6spQydw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: Martin Peres Cc: Jean Delvare , nouveau , "lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org" , Guenter Roeck List-Id: nouveau.vger.kernel.org QW0gRG9ubmVyc3RhZywgZGVuIDAzLjAzLjIwMTEsIDE4OjI5ICswMTAwIHNjaHJpZWIgTWFydGlu IFBlcmVzOgo+IExlIDAzLzAzLzIwMTEgMTY6MjIsIEd1ZW50ZXIgUm9lY2sgYSDDqWNyaXQgOgo+ ID4gT24gVGh1LCBNYXIgMDMsIDIwMTEgYXQgMDQ6MzY6MDlBTSAtMDUwMCwgRGF2ZSBBaXJsaWUg d3JvdGU6Cj4gPj4gT24gTW9uLCBGZWIgMTQsIDIwMTEgYXQgODowOCBBTSwgSmVhbiBEZWx2YXJl PGtoYWxpQGxpbnV4LWZyLm9yZz4gIHdyb3RlOgo+ID4+PiBPbiBTdW4sIDEzIEZlYiAyMDExIDA5 OjE2OjQwIC0wODAwLCBHdWVudGVyIFJvZWNrIHdyb3RlOgo+ID4+Pj4gT24gU3VuLCBGZWIgMTMs IDIwMTEgYXQgMDc6MTg6NDRBTSAtMDUwMCwgTWFydGluIFBlcmVzIHdyb3RlOgo+ID4+Pj4+IEhp LAo+ID4+Pj4+Cj4gPj4+Pj4gSSBhbSB3b3JraW5nIG9uIHBvd2VyIG1hbmFnZW1lbnQgb24gdGhl IG5vdXZlYXUgZHJpdmVyIGFuZCBJIG5lZWQgYSB3YXkKPiA+Pj4+PiB0byBnZXQgZGF0YSBvdXQg b2YgYW5kIHNlbmQgY29tbWFuZHMgdG8gdGhlIGkyYyBkcml2ZXJzIGZyb20gdGhlIGtlcm5lbAo+ ID4+Pj4+IHNwYWNlLgo+ID4+IE1hcnRpbiwKPiA+Pgo+ID4+IHlvdSBwcm9iYWJseSBzaG91bGQg aGF2ZSBjYydlZCBNYXR0aGV3IHNpbmNlIGl0IHdhcyBoaXMgcGF0Y2ggeW91IGJhc2VkIHRoaXMg b24sCj4gPj4gYW5kIEkgdGhpbmsgaGUgY2FuIHByb3ZpZGUgYSBnb29kIGV4cGxhaW5hdGlvbi4K PiA+Pgo+ID4+IHRvIGNsYXJpZnkgc29tZSBwb2ludHMsCj4gPj4KPiA+PiByYWRlb24gZG9lcyBw cm9iYWJseSB3YW50IHNvbWV0aGluZyBleGFjdGx5IGxpa2UgdGhpcywgd2UganVzdCBoYXZlbid0 IGdvdHRlbiB0bwo+ID4+IGl0IGNvbXBsZXRlbHkgeWV0LCBJJ2QgcmF0aGVyIG5vdCBoYXZlIHR3 byBkcml2ZXJzIGluIHRoZSBrZXJuZWwgZm9yCj4gPj4gZXhhY3Qgc2FtZSBoYXJkd2FyZSwKPiA+ PiBhbmQgSSBiZWxpZXZlIHNoYXJpbmcgdGhlIGh3bW9uIGNvZGUgdG8gZG8gd2hhdCB3ZSB3YW50 IGlzIGEgZ29vZCBwbGFuIHNpbmNlIHlvdQo+ID4+IGRvbid0IGdvIGFyb3VuZCByZWludmVudGlu ZyB3aGVlbHMsIGJ1dCBpZiBod21vbi9pMmMgbWFpbnRhaW5lcnMgaGF2ZQo+ID4+IG5vIGludGVy ZXN0Cj4gPj4gaXQgbGVhdmVzIHdpdGggbGl0dGxlIGNob2ljZSBidXQgdG8gaW1wbGVtZW50IGFi b3V0IDUtMTAgaTJjIGRyaXZlcnMKPiA+PiBhZ2FpbiBpbiBkcm0gY29kZWJhc2UuCj4gPj4KPiA+ PiBNYXliZSBod21vbi9pMmMgbWFpbnRhaW5lcnMgY291bGQgc3VnZ2VzdCBhIGNsZWFuZXIgd2F5 IHRvIGltcGxlbWVudAo+ID4+IHdoYXQgd2Ugd2FudCwKPiA+PiB3aGljaCBJIHRoaW5rIEkgY2Fu IHN1bW1hcml6ZSBhcwo+ID4+Cj4gPj4gYSkgYWNjZXNzIHRvIG1vbml0b3JlZCB2YWx1ZXMgaW4t a2VybmVsCj4gPj4gYikgbm8gdXNlcnNwYWNlIGFjY2VzcyB0byB0aGUgc2FtZSB2YWx1ZXMgZXhj ZXB0IHZpYSBzYW5pdGlzZWQgdmlhIHRoZSBkcml2ZXIuCj4gPj4KPiA+IFRoaXMgaXMgbm90IGEg bWF0dGVyIG9mICJubyBpbnRlcmVzdCIuIEludGVyZXN0IGlzIHRoZXJlLCBidXQgaWYgb25lIGRl bWFuZHMKPiA+IHRvbyBtdWNoIG9uZSBtYXkgZ2V0IG5vdGhpbmcuCj4gPgo+ID4gUmVxdWVzdCBm b3IgYikgc28gZmFyIHdhcyAibm8gdXNlcnNwYWNlIGFjY2VzcyIsIHBlcmlvZC4gVGhpcyBpcyB1 bmFjY2VwdGFibGUKPiA+IHNpbmNlIHByb3ZpZGluZyB1c2Vyc3BhY2UgYWNjZXNzIHRvIG1vbml0 b3JlZCB2YWx1ZXMgaXMgdGhlIHdob2xlIHBvaW50IG9mIGh3bW9uLgoKQW5kIHRoYXQgaXMgd2hh dCB3ZSB3YW50IHRvIGRvLiBCdXQgaXQgd291bGQgYmUgbmljZSBpZiB0aGUgZ3JhcGhpY3MKZHJp dmVycyBjb3VsZCBwcm92aWRlIGEgX3NpbmdsZV8gaW50ZXJmYWNlIHRvIHVzZXJzcGFjZS4gTm90 IGFsbCBib2FyZHMKaGF2ZSBpMmMgaGFyZHdhcmUgbW9uaXRvcmluZyBjaGlwcyBhbmQgd2l0aCBh IHNpbmdsZSBpbnRlcmZhY2Ugd2UgY291bGQKZmFsbCBiYWNrIHRvIHRoZSBpbnRlcm5hbCBncHUg c2Vuc29yLCB0cmFuc3BhcmVudGx5IGZvciB0aGUgdXNlci4KCj4gPgo+ID4gSSBjb3VsZCBpbWFn aW5lIGFuIEFQSSB0aGF0IGNvdmVycyBib3RoIGEpIGFuZCBiKSwgYXMgbG9uZyBhcyBiKSBmb2N1 c2VzCj4gPiBvbiB0aGUgInNhbml0aXplIiBhc3BlY3QgYW5kIGRvZXNuJ3QgdHJ5IHRvIGxpbWl0 IHVzZXJzcGFjZSBhY2Nlc3MgdG8gYXR0cmlidXRlcy4KPiA+Cj4gPiBHdWVudGVyCj4gYikgd2Fz IGludHJvZHVjZWQgYnkgRGF2ZSwgSSBuZXZlciBhc2tlZCBmb3IgaXQgYmVjYXVzZSBJIGRvbid0 IG1pbmQgCj4gZHVwbGljYXRpbmcgc2Vuc29yIGRhdGEgKG9uZSBod21vbiBkZXZpY2UgbmFtZWQg bm91dmVhdSBhbmQgb25lIGZvciB0aGUgCj4gcmF3IGFjY2VzcyB0byB0aGUgaTJjIGNoaXApLgoK U29ycnkgZm9yIHRoZSBjb25mdXNpb24gTWFydGluLCBJIGJyb3VnaHQgdXAgdGhlIHBvaW50IG9m IGxpbWl0aW5nCnVzZXJzcGFjZSBhY2Nlc3MgYW5kIGRpZCBub3QgY2MgdGhlIG5vdXZlYXUgbWFp bGluZyBsaXN0LiBJIHRoaW5rIGl0IGlzCmJhZCBiZWhhdmlvdXIgdG8gZXhwb3NlIHZhbHVlcyB0 byB1c2Vyc3BhY2Ugd2hpY2ggYXJlIHRvdGFsbHkgb2ZmIHRoZQpyZWFsIHZhbHVlcy4gVGhpcyBj b25mdXNlcyB1c2VycyBhbmQgc2hvdWxkIGJlIGF2b2lkZWQsIGVzcGVjaWFsbHkgc2luY2UKd2Ug Y2FuIHByb3ZpZGUgc2FuaXRpemVkIHZhbHVlcy4KCldoeSBzaG91bGQgd2UgcHVzaCB0aGUgbG9n aWMgYW5kIGFwaSBmb3Igc2FuaXRpemluZyB0aGUgdmFsdWVzIHRvIG1hbnkKaHdtb24gZHJpdmVy cyBpZiB3ZSBjb3VsZCBlYXNpbHkgZG8gdGhpcyBhdCBhIHNpbmdsZSBwb2ludCBpbiB0aGUKZ3Jh cGhpY3MgZHJpdmVyLCBpZiB3ZSBwcm92aWRlIHRoZSB1c2Vyc3BhY2UgaW50ZXJmYWNlIG91cnNl bGYgYW5kIHVzZQp0aGUgaHdtb24gZHJpdmVyIG9ubHkgdG8gaW5zdHJ1bWVudCB0aGUgbW9uaXRv cmluZyBjaGlwPwoKPiBNeSBvbmx5IHdpc2ggd2FzIHRvIHByb3ZpZGUgYSBzaW1wbGUgd2F5IGZv ciB1c2VycyB0byByZWFkL2NoYW5nZSB0aGVpciAKPiBmYW4gc3BlZWQgYW5kIGdldCB0aGUgR1BV IHRlbXBlcmF0dXJlIG5vIG1hdHRlciBpZiB0aGVpciBjYXJkIGhhdmUgYW4gCj4gaTJjIGNvbnRy b2xsZXIgb3Igbm90Lgo+IEkgZG8gYWdyZWUgdGhhdCBzYW5pdGl6aW5nIGNvdWxkIGJlIG9mIGlu dGVyZXN0LCBJIGVzcGVjaWFsbHkgdGhpbmsgCj4gYWJvdXQgdHdlYWtpbmcgdGhlIHRlbXBlcmF0 dXJlIHZhbHVlIHdpdGggcGFyYW1ldGVycyBzdG9yZWQgaW5zaWRlIHRoZSAKPiB2Ymlvcy4KPiAK PiBJIGFtIGZ1bGx5IG9wZW4gdG8gc3VnZ2VzdGlvbnMgYXMgbG9uZyBhcyBpdCBpbnZvbHZlcyBz aGFyaW5nIHRoZSBjb2RlIAo+IGluIG9uZSB3YXkgb3IgYW5vdGhlci4KPiAKPiBNYXJ0aW4KPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IE5vdXZlYXUg bWFpbGluZyBsaXN0Cj4gTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vbm91dmVhdQo+IAoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5vdXZlYXUgbWFpbGluZyBs aXN0Ck5vdXZlYXVAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9ub3V2ZWF1Cg==