All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Kirill A. Shutsemov" <kirill@shutemov.name>
Cc: Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
	containers@lists.linux-foundation.org,
	jacob.jun.pan@linux.intel.com,
	Arjan van de Ven <arjan@linux.intel.com>,
	linux-kernel@vger.kernel.org, Matt Helsley <matthltc@us.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-api@vger.kernel.org
Subject: Re: [PATCH, v7] cgroups: introduce timer slack controller
Date: Fri, 04 Mar 2011 20:03:42 +0100	[thread overview]
Message-ID: <1299265422.22521.2.camel@laptop> (raw)
In-Reply-To: <1299084001-3916-2-git-send-email-kirill@shutemov.name>

On Wed, 2011-03-02 at 18:40 +0200, Kirill A. Shutsemov wrote:
> -       if (ret < current->timer_slack_ns)
> -               return current->timer_slack_ns;
> -       return ret;
> +       return clamp(__estimate_accuracy(&now),
> +                       get_task_timer_slack(current), LONG_MAX);

That actually makes the code worse, how about:

  min(__estimate_accuracy(), get_task_timer_slack()) ?

  parent reply	other threads:[~2011-03-04 19:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02 16:40 [PATCH, v7] Introduce timer slack controller Kirill A. Shutsemov
2011-03-02 16:40 ` Kirill A. Shutsemov
     [not found] ` <1299084001-3916-1-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-03-02 16:40   ` [PATCH, v7] cgroups: introduce " Kirill A. Shutsemov
2011-03-02 16:40   ` Kirill A. Shutsemov
2011-03-02 16:40     ` Kirill A. Shutsemov
     [not found]     ` <1299084001-3916-2-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-03-02 18:40       ` Thomas Gleixner
2011-03-02 18:40       ` Thomas Gleixner
2011-03-02 18:40         ` Thomas Gleixner
     [not found]         ` <alpine.LFD.2.00.1103021912090.2701-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2011-03-03  6:59           ` Li Zefan
2011-03-03  6:59           ` Li Zefan
2011-03-03  6:59             ` Li Zefan
     [not found]             ` <4D6F3C5B.8020307-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2011-03-03  7:34               ` Thomas Gleixner
2011-03-03  7:34                 ` Thomas Gleixner
2011-03-03  7:34               ` Thomas Gleixner
2011-03-03  7:46           ` Matt Helsley
2011-03-03  7:46             ` Matt Helsley
     [not found]             ` <20110303074609.GL14893-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2011-03-03  8:28               ` Thomas Gleixner
2011-03-03  8:28                 ` Thomas Gleixner
2011-03-03  8:28               ` Thomas Gleixner
2011-03-03  7:46           ` Matt Helsley
2011-03-03  8:33           ` Kirill A. Shutemov
2011-03-03  8:33             ` Kirill A. Shutemov
2011-03-03  8:33           ` Kirill A. Shutemov
2011-03-04 19:03       ` Peter Zijlstra
2011-03-04 19:03     ` Peter Zijlstra [this message]
2011-03-04 23:22       ` Kirill A. Shutemov
2011-03-04 23:22         ` Kirill A. Shutemov
2011-03-04 23:22       ` Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299265422.22521.2.camel@laptop \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@linux.intel.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=kirill@shutemov.name \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=matthltc@us.ibm.com \
    --cc=menage@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.