From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Paulraj, Sandeep" <s-paulraj@ti.com>
Cc: "davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: RE: [PATCH] NAND: DaVinci: Removed header file that is not required
Date: Mon, 07 Mar 2011 19:57:52 +0200 [thread overview]
Message-ID: <1299520672.27552.1.camel@koala> (raw)
In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5DC266C260@dlee01.ent.ti.com>
On Mon, 2011-03-07 at 08:57 -0600, Paulraj, Sandeep wrote:
> >
> > On Tue, 2011-03-01 at 17:40 -0500, s-paulraj@ti.com wrote:
> > > From: Sandeep Paulraj <s-paulraj@ti.com>
> > >
> > > The DaVinci NAND driver was including the mach-types.h header
> > > file.
> > > This prevented the DaVinci NAND driver from getting used
> > > in a DSP only device. The linux port on c6x devices can make
> > > use of the same driver and does not define a corresponding
> > > header file; so removing it.
> > >
> > > Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
> >
> > Hi,
> >
> > you explain why this include is bad for DSP. Buy you do not explain
> why
> > this include is there and why removing it is harmless for Linux.
> >
>
> Hi,
>
> This header file was required in the driver because earlier there was
> code dependent on a machine_* check. This piece of code has now been
> factored out and is in /arch/arm/mach-davinci/aemif.c.
>
> Thus removing it is harmless.
>
> Please do let me know if you need an updated patch.
Yes, please, patch description should contain this important
information.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
prev parent reply other threads:[~2011-03-07 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 22:40 [PATCH] NAND: DaVinci: Removed header file that is not required s-paulraj
2011-03-07 9:01 ` Artem Bityutskiy
2011-03-07 14:57 ` Paulraj, Sandeep
2011-03-07 17:57 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299520672.27552.1.camel@koala \
--to=dedekind1@gmail.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=s-paulraj@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.