From: Brian Koropoff <bkoropoff@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: dash@vger.kernel.org
Subject: Re: [PATCH 3/3] Port to HP-UX
Date: Sat, 12 Mar 2011 15:54:43 -0800 [thread overview]
Message-ID: <1299974083.3797.7.camel@gemini> (raw)
In-Reply-To: <20110310122636.GE10824@gondor.apana.org.au>
AC_CHECK_FUNC just checks that the symbol exists in libc, so it
succeeds. _LARGEFILE64_SOURCE is necessary to get the system headers to
give you function prototypes, but it doesn't affect the configure test.
-- Brian
On Thu, 2011-03-10 at 20:26 +0800, Herbert Xu wrote:
> On Wed, Jan 19, 2011 at 05:16:02AM +0000, Brian Koropoff wrote:
> >
> > - HP-UX needs _LARGEFILE64_SOURCE to be defined for open64()
> > and friends to be available. This seems to be safe to
> > define everywhere, so do so.
>
> Shouldn't this go into configure.ac? In fact, how can your patch
> have any effect if configure.ac doesn't detect open64 in the
> first place?
>
> The rest looks OK.
>
> Thanks,
next prev parent reply other threads:[~2011-03-12 23:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 5:07 Portability patches Brian Koropoff
2011-01-19 5:15 ` [PATCH 1/3] Port to Solaris Brian Koropoff
2011-01-21 13:06 ` Jilles Tjoelker
2011-03-10 12:16 ` Herbert Xu
2011-03-13 1:18 ` Brian Koropoff
2011-03-13 1:25 ` [PATCH] " Brian Koropoff
2011-03-15 7:36 ` Herbert Xu
2011-01-19 5:15 ` [PATCH 2/3] Port to AIX Brian Koropoff
2011-03-10 12:25 ` Herbert Xu
2011-01-19 5:16 ` [PATCH 3/3] Port to HP-UX Brian Koropoff
2011-03-10 12:26 ` Herbert Xu
2011-03-12 23:54 ` Brian Koropoff [this message]
2011-03-15 7:38 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299974083.3797.7.camel@gemini \
--to=bkoropoff@gmail.com \
--cc=dash@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.