RE: [v2] Bluetooth: btrtl: Firmware format v2 support

[Max Chou <max.chou@realtek.com>]

Hi! Luiz,
Thanks for your info that the new API to implement firmware uploaded.
We will study it and try to implement it in the future.
In this patch, it's implemented for the firmware data parsing due to Realtek firmware format changed as V2.
Could you have the advice which can supports this patch be approved? Thanks.


BRs,
Max


-----Original Message-----
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com> 
Sent: Friday, February 3, 2023 6:03 AM
To: linux-bluetooth@vger.kernel.org
Cc: Max Chou <max.chou@realtek.com>
Subject: Re: [v2] Bluetooth: btrtl: Firmware format v2 support

Hi Max,

On Thu, Feb 2, 2023 at 4:44 AM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW 
> Link:https://patchwork.kernel.org/project/bluetooth/list/?series=71811
> 7
>
> ---Test result---
>
> Test Summary:
> CheckPatch                    PASS      1.47 seconds
> GitLint                       FAIL      0.59 seconds
> SubjectPrefix                 PASS      0.12 seconds
> BuildKernel                   PASS      32.41 seconds
> CheckAllWarning               PASS      34.42 seconds
> CheckSparse                   WARNING   39.28 seconds
> CheckSmatch                   WARNING   107.00 seconds
> BuildKernel32                 PASS      30.51 seconds
> TestRunnerSetup               PASS      438.93 seconds
> TestRunner_l2cap-tester       PASS      16.68 seconds
> TestRunner_iso-tester         PASS      17.51 seconds
> TestRunner_bnep-tester        PASS      5.83 seconds
> TestRunner_mgmt-tester        PASS      113.14 seconds
> TestRunner_rfcomm-tester      PASS      9.24 seconds
> TestRunner_sco-tester         PASS      8.45 seconds
> TestRunner_ioctl-tester       PASS      9.90 seconds
> TestRunner_mesh-tester        PASS      7.34 seconds
> TestRunner_smp-tester         PASS      8.30 seconds
> TestRunner_userchan-tester    PASS      6.11 seconds
> IncrementalBuild              PASS      28.50 seconds
>
> Details
> ##############################
> Test: GitLint - FAIL
> Desc: Run gitlint
> Output:
> [v2] Bluetooth: btrtl: Firmware format v2 support
>
> WARNING: I3 - ignore-body-lines: gitlint will be switching from using 
> Python regex 'match' (match beginning) to 'search' (match anywhere) 
> semantics. Please review your ignore-body-lines.regex option 
> accordingly. To remove this warning, set 
> general.regex-style-search=True. More details: 
> https://jorisroovers.github.io/gitlint/configuration/#regex-style-sear
> ch
> 24: B1 Line exceeds max length (83>80): "> I rather use an skb for parsing the data instead of parsing via pointer directly,"
> ##############################
> Test: CheckSparse - WARNING
> Desc: Run sparse tool with linux kernel
> Output:
> drivers/bluetooth/btrtl.c:882:22: warning: cast to restricted 
> __le16drivers/bluetooth/btrtl.c:888:27: warning: cast to restricted 
> __le16drivers/bluetooth/btrtl.c: note: in included 
> file:drivers/bluetooth/btrtl.h:47:45: warning: array of flexible 
> structures ##############################
> Test: CheckSmatch - WARNING
> Desc: Run smatch tool with source
> Output:
> drivers/bluetooth/btrtl.c: note: in included 
> file:drivers/bluetooth/btrtl.h:47:45: warning: array of flexible 
> structures
>
>
> ---
> Regards,
> Linux Bluetooth

Id give a look at:

https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/tree/Documentation/driver-api/firmware/fw_upload.rst

There are not so many drivers since it was introduced last year but from the looks of it it has a nice abstraction for handling firmware uploads.


--
Luiz Augusto von Dentz

------Please consider the environment before printing this e-mail.