From: Pavel Begunkov <asml.silence@gmail.com>
To: io-uring <io-uring@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>
Subject: [RFC] do_iopoll() and *grab_env()
Date: Thu, 11 Jun 2020 18:54:09 +0300 [thread overview]
Message-ID: <12b44e81-332e-e53c-b5fa-09b7bf9cc082@gmail.com> (raw)
io_do_iopoll() can async punt a request with io_queue_async_work(),
so doing io_req_work_grab_env(). The problem is that iopoll() can
be called from who knows what context, e.g. from a completely
different process with its own memory space, creds, etc.
io_do_iopoll() {
ret = req->poll();
if (ret == -EAGAIN)
io_queue_async_work()
...
}
I can't find it handled in io_uring. Can this even happen?
Wouldn't it be better to complete them with -EAGAIN?
--
Pavel Begunkov
next reply other threads:[~2020-06-11 15:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 15:54 Pavel Begunkov [this message]
2020-06-12 17:02 ` [RFC] do_iopoll() and *grab_env() Jens Axboe
2020-06-12 17:30 ` Pavel Begunkov
2020-06-12 17:55 ` Jens Axboe
2020-06-12 18:02 ` Jens Axboe
2020-06-12 18:33 ` Pavel Begunkov
2020-06-12 18:46 ` Pavel Begunkov
2020-06-12 19:42 ` Jens Axboe
2020-06-13 19:12 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12b44e81-332e-e53c-b5fa-09b7bf9cc082@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.