All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wu. JackBB (GSM)" <JackBB_Wu@compal.com>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: Sergey Ryazanov <ryazanov.s.a@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Wen-Zhi Huang <wen-zhi.huang@mediatek.com>,
	Shi-Wei Yeh <shi-wei.yeh@mediatek.com>,
	Minano Tseng <Minano.tseng@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	"Yu. Robert (GSM)" <robert_yu@compal.com>,
	"Chang. Jeff (GSM)" <Jeff_Chang@compal.com>,
	Eric Dumazet <edumazet@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: RE: [External Mail] Re: [PATCH net-next v12 1/6] net: wwan: t9xx: Add PCIe core
Date: Wed, 18 Nov 2026 02:41:31 +0000	[thread overview]
Message-ID: <12b4684bdb85447583e859b2b9b225d4@compal.com> (raw)
In-Reply-To: <CAFEp6-1r=SYCSvUNj_Up346vFssTFckWX8qg_Y_AWAfNX-jUpw@mail.gmail.com>

Hi Loic,

Thanks for the review.

On Tue, Nov 17, 2026 at 11:28 PM Loic Poulain <loic.poulain@oss.qualcomm.com> wrote:
> > +       if (acpi_disabled) {
> > +               dev_dbg(mdev->dev, "Unsupported, acpi function isn't enable\n");
>
> Go straight to the point: "ACPI is disabled\n"

Will fix in v13, with that wording.

> > +       handle = ACPI_HANDLE(mdev->dev);
> > +       if (!handle) {
> > +               dev_dbg(mdev->dev, "Unsupported, acpi handle isn't found\n");
> > +               return -ENODEV;
> > +       }
> > +       if (!acpi_has_method(handle, "MRST._RST")) {
> > +               dev_dbg(mdev->dev, "Unsupported, pldr method isn't supported\n");
>
> "ACPI handle not found"

Will fix in v13: "ACPI handle not found" for the missing handle, and
"MRST._RST method not found" for the missing method.

> > +       strscpy(mdev->dev_str, pci_name(pdev), MTK_DEV_STR_LEN);
>
> Do we really need this buffer to exist solely for IRQ names, can't we
> simply use dev_name()?

Will fix in v13: dev_str goes away and every name is built from
dev_name().  pci_request_irq() gets the format directly, so the per-IRQ
name buffer goes away as well.

Thanks,
Jack

  reply	other threads:[~2026-11-18  2:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 10:50 [PATCH net-next v12 0/6] net: wwan: t9xx: Add MediaTek T9XX WWAN driver Jack Wu
2026-11-17 10:50 ` Jack Wu via B4 Relay
2026-11-17 10:50 ` [PATCH net-next v12 1/6] net: wwan: t9xx: Add PCIe core Jack Wu
2026-11-17 10:50   ` Jack Wu via B4 Relay
2026-11-17 15:28   ` Loic Poulain
2026-11-18  2:41     ` Wu. JackBB (GSM) [this message]
2026-11-17 10:50 ` [PATCH net-next v12 2/6] net: wwan: t9xx: Add control plane transaction layer framework Jack Wu
2026-11-17 10:50   ` Jack Wu via B4 Relay
2026-11-17 15:31   ` Loic Poulain
2026-11-18  2:44     ` Wu. JackBB (GSM)
2026-11-17 10:50 ` [PATCH net-next v12 3/6] net: wwan: t9xx: Add control DMA interface Jack Wu
2026-11-17 10:50   ` Jack Wu via B4 Relay
2026-11-17 10:50 ` [PATCH net-next v12 4/6] net: wwan: t9xx: Add control port Jack Wu
2026-11-17 10:50   ` Jack Wu via B4 Relay
2026-11-17 10:50 ` [PATCH net-next v12 5/6] net: wwan: t9xx: Add FSM thread Jack Wu
2026-11-17 10:50   ` Jack Wu via B4 Relay
2026-11-17 10:50 ` [PATCH net-next v12 6/6] net: wwan: t9xx: Add AT & MBIM WWAN ports Jack Wu
2026-11-17 10:50   ` Jack Wu via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12b4684bdb85447583e859b2b9b225d4@compal.com \
    --to=jackbb_wu@compal.com \
    --cc=Jeff_Chang@compal.com \
    --cc=Minano.tseng@mediatek.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robert_yu@compal.com \
    --cc=ryazanov.s.a@gmail.com \
    --cc=shi-wei.yeh@mediatek.com \
    --cc=skhan@linuxfoundation.org \
    --cc=wen-zhi.huang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.