All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Luck <tony.luck@gmail.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Linus Torvalds <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ia64 basic __user annotations
Date: Thu, 29 Sep 2005 13:27:41 -0700	[thread overview]
Message-ID: <12c511ca050929132743f946f1@mail.gmail.com> (raw)
In-Reply-To: <20050928231213.GG7992@ftp.linux.org.uk>

On 9/28/05, Al Viro <viro@ftp.linux.org.uk> wrote:
>         * uintptr_t is unsigned long, not long

> -       long __gu_err = -EFAULT, __gu_val = 0;                                          \
> -                                                                                       \
> +       long __gu_err = -EFAULT;                                                        \
> +       unsigned long __gu_val = 0;                                                     \

Too subtle for me ... what's happening here?  If you change this, then
should you also change "register long __gu_r9 asm ("r9");" in __get_user_size
to be unsigned long as well?

-Tony

      reply	other threads:[~2005-09-29 20:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-28 23:12 [PATCH] ia64 basic __user annotations Al Viro
2005-09-29 20:27 ` Tony Luck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12c511ca050929132743f946f1@mail.gmail.com \
    --to=tony.luck@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.