All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Luck <tony.luck@gmail.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Fwd: Weird ia64 problem]
Date: Sat, 08 Oct 2005 02:40:54 +0000	[thread overview]
Message-ID: <12c511ca0510071940m3e1278d9vb2f708c65aa43cc3@mail.gmail.com> (raw)
In-Reply-To: <1128548614.4623.45.camel@laptop1>

> I'm thinking it should check if (PIPE_SIZE - buf->len) > PIPE_BUF, and
> set do_wakeup.  The code could be #defined out if PIPE_SIZE = PIPE_BUF,
> so the change reduces to a no-op on other archs.
>
> Does that sound right?  I'm going to work on a patch here.

Roughly (without looking back as fs/pipe.c).  When you have your
patch, you will need to restart this discussion on the linux-kernel
mailing list (since you'll be touching a generic file).  Some random
grepping for PAGE_SIZE (well PAGE_SHIFT) shows that some
other artchitectures have some support for page size > PIPE_BUF.
So there should be some interest in this fix.

-Tony

      parent reply	other threads:[~2005-10-08  2:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-05 21:43 [Fwd: Weird ia64 problem] Jeff Licquia
2005-10-05 21:54 ` Luck, Tony
2005-10-05 22:09 ` Luck, Tony
2005-10-05 22:13 ` Jeff Licquia
2005-10-05 22:30 ` Jeff Licquia
2005-10-05 22:33 ` Luck, Tony
2005-10-05 23:09 ` Jeff Licquia
2005-10-05 23:28 ` Luck, Tony
2005-10-05 23:40 ` Luck, Tony
2005-10-06  1:02 ` Ian Wienand
2005-10-07 14:29 ` Jeff Licquia
2005-10-08  2:40 ` Tony Luck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12c511ca0510071940m3e1278d9vb2f708c65aa43cc3@mail.gmail.com \
    --to=tony.luck@gmail.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.