All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tony Luck" <tony.luck@intel.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] Ensure PSR.ac is cleared for early userspace
Date: Sat, 15 Nov 2008 19:57:29 +0000	[thread overview]
Message-ID: <12c511ca0811151157u71abfecfn3361885167a2d540@mail.gmail.com> (raw)
In-Reply-To: <200811120135.mAC1ZoSd017352@agluck-lia64.sc.intel.com>

On Fri, Nov 14, 2008 at 7:26 PM, David Mosberger-Tang
<dmosberger@gmail.com> wrote:
>  In any case, as I remember, the idea was that the kernel would always
>  execute with PSR.AC=1 to avoid silent performance bugs and just since
>  the kernel should be alignment-clean, anyhow.  The fys-code doesn't
>  turn on PSR.AC, but I believe the heavy-weight syscall path does.  I
>  don't know why head.S turns off PSR.AC.  Seems like a bug to me.

Running base code and interrupt/trap code with different settings of PSR.ac
does sound like a bug ... but the question of what we should set it to deserves
a little more thought.

Perhaps the best option would be for test & development kernels to set
PSR.ac=1 to aid in tracking down any alignment problems in the code.
But production kernels should set PSR.ac=0 so that they don't take the
cost of a trap on unaligned access that the specific model of processor
can handle anyway.  If this is the right path, then it should become a
CONFIG option.

-Tony

  parent reply	other threads:[~2008-11-15 19:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-12  1:35 [PATCH] Ensure PSR.ac is cleared for early userspace Luck, Tony
2008-11-13  6:22 ` Isaku Yamahata
2008-11-15  1:38 ` Luck, Tony
2008-11-15  3:03 ` David Mosberger-Tang
2008-11-15 19:57 ` Tony Luck [this message]
2008-11-17 18:59 ` Rick Jones
2008-11-17 19:45 ` Luck, Tony
2008-11-17 19:52 ` Rick Jones
2008-11-17 20:58 ` Luck, Tony
2008-11-18  7:06 ` Petr Tesarik
2008-11-18  7:12 ` Matthew Wilcox
2008-11-18 11:58 ` Robin Holt
2008-11-20 22:45 ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12c511ca0811151157u71abfecfn3361885167a2d540@mail.gmail.com \
    --to=tony.luck@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.