From: "Yajun Deng" <yajun.deng@linux.dev>
To: "Dave Hansen" <dave.hansen@intel.com>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com
Cc: noodles@fb.com, ross.philipson@oracle.com,
daniel.kiper@oracle.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/e820: make e820 type string uniform
Date: Fri, 21 Oct 2022 02:52:09 +0000 [thread overview]
Message-ID: <12e1236e3200c03b7fb2771cf7f8f72a@linux.dev> (raw)
In-Reply-To: <8f84e984-c42b-b672-c9db-e7d4464b2a15@intel.com>
October 20, 2022 11:44 PM, "Dave Hansen" <dave.hansen@intel.com> wrote:
> On 10/20/22 04:56, Yajun Deng wrote:
>
>> /proc/iomem:
>> ...
>> 00000000-00000fff : Reserved
>> 00001000-0005efff : System RAM
>> 0005f000-0005ffff : Reserved
>> 00060000-0009ffff : System RAM
>> 000a0000-000fffff : Reserved
>> 000a0000-000bffff : PCI Bus 0000:00
>> 000c0000-000cddff : Video ROM
>> 000f0000-000fffff : System ROM
>> 00100000-80ff3017 : System RAM
>> 80ff3018-81003e57 : System RAM (kernel)
>> 81003e58-81004017 : System RAM
>> 81004018-81023c57 : System RAM (kernel)
>> 81023c58-87672fff : System RAM
>
> I guess this is a pretty minimal change. It definitely makes
> /proc/iomem more human-readable.
>
> Did you consider if this change might break any users of this file?
Yes, it may be.
I don't know how many users use this file, but I think the impact of this change is limited.
1st: This is not the first time this file has been changed. In commit
ad5fb870c486("e820, efi: add ACPI 6.0 persistent memory types"), the E820_PRAM changed
from "Persistent RAM" to "Persistent Memory (legacy)".
2nd: only super users can access the full information from /proc/iomem, which means the users
of this file are limited.
In commit 51d7b120418e("/proc/iomem: only expose physical resource addresses to privileged users")
3rd: The E820_TYPE_RESERVED_KERN changed from "System RAM" to "System RAM (kernel)" is a minimal change,
and it also contains the "System RAM" string.
prev parent reply other threads:[~2022-10-21 2:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 11:56 [PATCH] x86/e820: make e820 type string uniform Yajun Deng
2022-10-20 15:44 ` Dave Hansen
2022-10-21 2:52 ` Yajun Deng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12e1236e3200c03b7fb2771cf7f8f72a@linux.dev \
--to=yajun.deng@linux.dev \
--cc=bp@alien8.de \
--cc=daniel.kiper@oracle.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=noodles@fb.com \
--cc=ross.philipson@oracle.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.