From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:d7a2:b0:96f:a786:ac5c with SMTP id pk2csp1280389ejb; Mon, 22 May 2023 08:21:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5O44KMPs9sNkS9c5SOrLw8ini1GnhasimJ6eh6yfjDaq3oXUO0fMit/d4seXhIQzdZ4OBZ X-Received: by 2002:ad4:5ceb:0:b0:5e8:c098:2493 with SMTP id iv11-20020ad45ceb000000b005e8c0982493mr21913803qvb.50.1684768910308; Mon, 22 May 2023 08:21:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684768910; cv=none; d=google.com; s=arc-20160816; b=vgGOOu/Z7b1cuWVaVGGRw7h2kclvxIeaga0+Vco1M3cZGh/OYxmHwWhyt7BiD/WiO+ QXGxUNlWHStW5feRwL+SIzWeRas1+xUqYT/tJHKSMe5HXPlFcO3JSKq58NSD+Bu7yp/E oGZW0AhqTubEDJEu1G1bWnKoIYEFUv75RwXwv7UZtPVMb8Ush0hjOiYGPGZ+l/eIApfP +XxZnjRwNdgUgE8a6gNBv71KzWLKp1vvpSEgLILGM1pKw7ib2ZvjPWzGyfvkgmbeZbtS qShwX+eBdU/uBl2vNw5IbsCUaxYXnXj03hlziDN4Wd4LeKaX6UF4PH/jSU4KaF+KWshM +5BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=9p7nmKMZnBxiCgyK0+rXDkd/Nk/6ERKDLJYV2JarmGg=; b=lRI7RoJ+nlOYqt4rFpPTTtPwPT+BThpWPS6SjvVR+gxoHKvr8V8B52Je46xx4TQyLS SH/WzwFvcwPF4AYugMwMf/a3BB7PmgFjVEhXkLJIfppMxlCaQT69CHcfXwV0kbd7b00B HSSh1tAbtF/fP/L81HiJs5OVYl9S5T1rugWmbSup81eQMHjdb1B+L+4FiIdQBUIpaAu8 UKJpO1Uk7iC3C7uBt7kN+XT4imI2Y1OmAn/rfrhBD1Kd8YEJbHM20lCX6YDGk3v4ey67 ZSEzirbv12CXXhOen9vLWQhNnA1BCXT0vZj3F9ImMN2eYmGgIVsUOynajJNGoohOp6U0 p1cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id eq15-20020ad4596f000000b0061face6e93fsi3619261qvb.404.2023.05.22.08.21.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 May 2023 08:21:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q17LX-000499-Kb; Mon, 22 May 2023 11:21:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q17LV-00048L-0r; Mon, 22 May 2023 11:21:13 -0400 Received: from hq-ms.auriga.com ([82.97.202.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q17LS-0007ER-Aa; Mon, 22 May 2023 11:21:12 -0400 Received: from HQ-MS1.office.auriga.msk (82.97.202.32) by hq-ms1.office.auriga.msk (82.97.202.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Mon, 22 May 2023 18:21:03 +0300 Received: from HQ-MS1.office.auriga.msk ([fe80::e2f8:5f63:adc1:868f]) by hq-ms1.office.auriga.msk ([fe80::e2f8:5f63:adc1:868f%8]) with mapi id 15.02.1258.012; Mon, 22 May 2023 18:21:03 +0300 From: "Kambalin, Sergey" To: =?gb2312?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkqKY=?= , "Sergey Kambalin" CC: Peter Maydell , "qemu-arm@nongnu.org" , "qemu-devel@nongnu.org" Subject: Re: [PATCH] [rpi4b] Make bootable rpi4b model Thread-Topic: [PATCH] [rpi4b] Make bootable rpi4b model Thread-Index: AQHZjJhM5s2DGZMhDE6fRKCxSTEX869l5goAgAA0A2T//9M1AIAAPGd6///VIACAAD0/pv//3tKAAAm20Kk= Date: Mon, 22 May 2023 15:21:03 +0000 Message-ID: <12ff45b45c334cbd8340becc512eaf89@auriga.com> References: <20230522102910.20942-1-sergey.kambalin@auriga.com> <672004b332154e15b14e4e96d20a23de@auriga.com>, <7fb1818b-7ed9-975a-3fa0-ebda7553aa73@linaro.org> In-Reply-To: <7fb1818b-7ed9-975a-3fa0-ebda7553aa73@linaro.org> Accept-Language: ru-RU, en-US Content-Language: ru-RU X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [134.191.220.81] x-tm-as-product-ver: SMEX-14.0.0.1158-9.0.1002-27556.003 x-tm-as-result: No-10--19.311900-8.000000 x-tmase-matchedrid: xOmkFxUSbL+JVA+ukO+5MWg4D2QV/2zL6r3HCixfuKcc4ri4RJV/1W/R DAZTdSI3QnEYvg6//klFmXhQ6rgRVOyDy8V8lTWUzH6d90mb4+Ih6cl1707zKlZxVB3B2qbP6Xk ezPna397QLE3MitZAfl9/IWsrV5Ek1LFdtmiebE5itzfafzhYerzutTz14s8pB4N9b2b2Ot6L2s CeHVx5vavLMqivPPjo9ElewkZ1UEQ2ib2gFI+X3zo39wOA02Lhv/7xdLQjXSIgaqPnI+BNyB2MH UpnrEwAiPTUF0vMdpHE2FTB6r9HbwcO+Ovs7EaQQQ5+hY6u+45PnKxAOPp4WdWM2x6EZ/S9InVh PozbL+m/+cseRgjV48XXGI8+1x81r8SWmHOl/UsRW4LR41Fi8mlYsa84w2hTOhR0VsdhRrBO6PM ltTuI3mUVI5FRUThe9el/AXqANCywquY0kEgdZxqkhv3OdF4DNQO+lFC5/FV3de2OoBqgwoKQCY LmjRv992grUwQgYZdOzTDkfilYT4JYxfHyi9oJ4vM1YF6AJbYXDmF9vUz9/rDGGXOPbPCbjI5fM 8fX0wmm0nvaK7VjdZXO/vat5d5TqTD/Ey87O1k2RRIMOrvjaQ== x-tm-as-user-approved-sender: No x-tm-as-user-blocked-sender: No x-tmase-result: 10--19.311900-8.000000 x-tmase-version: SMEX-14.0.0.1158-9.0.1002-27556.003 x-tm-snts-smtp: C7FCEDA10982392AC6ED3CD31848D6493928DA025B08D8B2B2F88AAAE5ABD7A52000:8 Content-Type: multipart/alternative; boundary="_000_12ff45b45c334cbd8340becc512eaf89aurigacom_" MIME-Version: 1.0 Received-SPF: pass client-ip=82.97.202.32; envelope-from=sergey.kambalin@auriga.com; helo=hq-ms.auriga.com X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, MIME_CHARSET_FARAWAY=2.45, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: r5OsQ90CUV5Y --_000_12ff45b45c334cbd8340becc512eaf89aurigacom_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 VGhhbmtzIGZvciB0aGUgZXhhbXBsZSwgUGhpbGxpcGUhIEl0J3MgaGVscGZ1bCENCg0KX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18NCqewp+Q6IFBoaWxpcHBlIE1hdGhpZXUtRGF1ZKim IDxwaGlsbWRAbGluYXJvLm9yZz4NCqewp+Sn4afip9Gn06fdp9an36fgOiAyMiCn3qfRp/EgMjAy MyCn1C4gMTY6NDE6NTMNCqesp+Cn3qflOiBTZXJnZXkgS2FtYmFsaW47IEthbWJhbGluLCBTZXJn ZXkNCqesp+Cn4afap/E6IFBldGVyIE1heWRlbGw7IHFlbXUtYXJtQG5vbmdudS5vcmc7IHFlbXUt ZGV2ZWxAbm9uZ251Lm9yZw0Kp7Sn1qfep9E6IFJlOiBbUEFUQ0hdIFtycGk0Yl0gTWFrZSBib290 YWJsZSBycGk0YiBtb2RlbA0KDQpPbiAyMi81LzIzIDE0OjQxLCBLYW1iYWxpbiwgU2VyZ2V5IHdy b3RlOg0KDQo+PiBDb3VsZCB5b3UgcGxlYXNlIHRlbGwgbWUgd2hhdCBzaXplIGlzIGFwcHJvcHJp YXRlIGZvciBhIHNpbmdsZSBwYXRjaD8NCj4NCj4gVGhlIG1vc3QgaW1wb3J0YW50IHRoaW5ncyBm b3IgcGF0Y2ggc3BsaXR0aW5nIGFyZToNCj4gICAqIGV2ZXJ5dGhpbmcgc3RpbGwgaGFzIHRvIGNv bXBpbGUgY2xlYW5seQ0KPiAgICogdGhlIGNvbnRlbnRzIG9mIGEgc2luZ2xlIHBhdGNoIHNob3Vs ZCBiZSBhIGNvaGVyZW50IHNpbmdsZQ0KPiAgICAgdGhpbmcgdGhhdCBpdCBtYWtlcyBzZW5zZSB0 byByZXZpZXcgaW4gb25lIHBhcnQNCj4NCj4gSWYgdGhlcmUncyBzb21ldGhpbmcgaW4gdGhlcmUg dGhhdCBvbmx5IHRvdWNoZXMgMjAgbGluZXMgb2YNCj4gY29kZSBidXQgaXMgYSBjb2hlcmVudCBz aW5nbGUgY2hhbmdlLCBpdCdzIGZpbmUgdG8gaGF2ZSB0aGF0IGluDQo+IGl0cyBvd24gcGF0Y2gg LS0gc21hbGwgcGF0Y2hlcyBhcmUgZWFzeSB0byByZXZpZXcuDQo+DQo+IEF0IHRoZSB1cHBlciBl bmQsIEkgdGVuZCB0byB0aGluayBhIHBhdGNoIGlzIGEgYml0IGJpZw0KPiBhdCBhcm91bmQgMjAw IGxpbmVzLCBidXQgZm9yIHRoZSBzcGVjaWZpYyBjYXNlIG9mICJoZXJlDQo+IGlzIGEgbmV3IGRl dmljZSIgYmlnZ2VyIHRoYW4gdGhhdCBpcyBPSywgYmVjYXVzZSBpdCdzDQo+IGp1c3QgYWRkaW5n IG5ldyBmaWxlcyByYXRoZXIgdGhhbiBtZXJnaW5nIGNoYW5nZXMgaW50bw0KPiBleGlzdGluZyBv bmVzLg0KPg0KPiBodHRwczovL3d3dy5xZW11Lm9yZy9kb2NzL21hc3Rlci9kZXZlbC9zdWJtaXR0 aW5nLWEtcGF0Y2guaHRtbA0KPiA8aHR0cHM6Ly93d3cucWVtdS5vcmcvZG9jcy9tYXN0ZXIvZGV2 ZWwvc3VibWl0dGluZy1hLXBhdGNoLmh0bWw+DQo+IGhhcyBzb21lIG90aGVyIGFkdmljZSBvbiBw YXRjaCBzdWJtaXNzaW9uLCBpZiB5b3UgaGF2ZW4ndA0KPiByZWFkIHRoYXQgeWV0Lg0KDQpGV0lX IGV4YW1wbGUgb2Ygc2VyaWVzIGFkZGluZyB0aGUgUGkgWmVybzoNCg0KaHR0cHM6Ly9sb3JlLmtl cm5lbC5vcmcvcWVtdS1kZXZlbC8yMDIwMTAyNDE3MDEyNy4zNTkyMTgyLTEtZjRidWdAYW1zYXQu b3JnLw0KDQo= --_000_12ff45b45c334cbd8340becc512eaf89aurigacom_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

Thanks for the example, Phillipe! It's helpful!

=A7=B0=A7=E4: Philippe Ma= thieu-Daud=A8=A6 <philmd@linaro.org>
=A7=B0=A7=E4=A7=E1=A7=E2=A7=D1=A7=D3=A7=DD=A7=D6=A7=DF=A7=E0: 22 =A7= =DE=A7=D1=A7=F1 2023 =A7=D4. 16:41:53
=A7=AC=A7=E0=A7=DE=A7=E5: Sergey Kambalin; Kambalin, Sergey
=A7=AC=A7=E0=A7=E1=A7=DA=A7=F1: Peter Maydell; qemu-arm@nongnu.org; = qemu-devel@nongnu.org
=A7=B4=A7=D6=A7=DE=A7=D1: Re: [PATCH] [rpi4b] Make bootable rpi4b mo= del
 
On 22/5/23 14:41, Kambalin, Sergey wrote:

>> Could you please tell me what size is appropriate for a single pat= ch?
>
> The most important things for patch splitting are:
>   * everything still has to compile cleanly
>   * the contents of a single patch should be a coherent sing= le
>     thing that it makes sense to review in one part
>
> If there's something in there that only touches 20 lines of
> code but is a coherent single change, it's fine to have that in
> its own patch -- small patches are easy to review.
>
> At the upper end, I tend to think a patch is a bit big
> at around 200 lines, but for the specific case of "here
> is a new device" bigger than that is OK, because it's
> just adding new files rather than merging changes into
> existing ones.
>
> https://www.qemu.org/docs/master/devel/submitting-a-patch.html
> <https://www.qemu.org/docs/master/devel/submitting-a-patch.html= >
> has some other advice on patch submission, if you haven't
> read that yet.

FWIW example of series adding the Pi Zero:

https://lore.kernel.org/qemu-devel/20201024170127.3592182-1-f= 4bug@amsat.org/

 --_000_12ff45b45c334cbd8340becc512eaf89aurigacom_--