From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Vince Weaver <vweaver1@eecs.utk.edu>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Ingo Molnar <mingo@elte.hu>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf: Fix tear-down of inherited group events
Date: Tue, 15 Mar 2011 17:41:23 +0100 [thread overview]
Message-ID: <1300207283.2203.213.camel@twins> (raw)
In-Reply-To: <alpine.DEB.2.00.1103151206140.9668@cl320.eecs.utk.edu>
On Tue, 2011-03-15 at 12:09 -0400, Vince Weaver wrote:
> On Tue, 15 Mar 2011, Peter Zijlstra wrote:
>
> > Subject: perf: Fix tear-down of inherited group events
> > From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Date: Tue Mar 15 14:37:10 CET 2011
> >
> > When destroying inherited events, we need to destroy groups too,
> > otherwise the event iteration in perf_event_exit_task_context() will
> > miss group siblings and we leak events with all the consequences.
>
> Thanks for the fix! I can verify that when applied against current
> linus-git kernel that my original test case no longer leaks memory.
>
> I've also run the full PAPI regression tests, plus the BLAS/PAPI benchmark
> code that originally showed the problem and everything checks out fine.
>
> It's a shame this fix didn't make it in before 2.6.38.
It sure is, sadly there's still only 24h in a day, less if you consider
this .jp earthquake speeding up our planets spin :-)
> Tested-by: Vince Weaver <vweaver1@eecs.utk.edu>
Thanks Vince!
next prev parent reply other threads:[~2011-03-15 16:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 22:54 perf: kernel memory leak when inherit enabled Vince Weaver
2011-03-14 22:27 ` Vince Weaver
2011-03-14 22:32 ` Arnaldo Carvalho de Melo
2011-03-15 0:27 ` Vince Weaver
2011-03-15 2:26 ` Vince Weaver
2011-03-15 13:41 ` [PATCH] perf: Fix tear-down of inherited group events Peter Zijlstra
2011-03-15 16:09 ` Vince Weaver
2011-03-15 16:41 ` Peter Zijlstra [this message]
2011-03-16 13:59 ` [tip:perf/urgent] " tip-bot for Peter Zijlstra
2011-03-15 9:07 ` perf: kernel memory leak when inherit enabled Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300207283.2203.213.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=vweaver1@eecs.utk.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.