From: Chris Mason <chris.mason@oracle.com>
To: Miao Xie <miaox@cn.fujitsu.com>
Cc: Itaru Kitayama <kitayama@cl.bb4u.ne.jp>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH V3] btrfs: implement delayed inode items operation
Date: Wed, 16 Mar 2011 13:49:36 -0400 [thread overview]
Message-ID: <1300297740-sup-2597@think> (raw)
In-Reply-To: <4D80C81F.60507@cn.fujitsu.com>
Excerpts from Miao Xie's message of 2011-03-16 10:24:31 -0400:
> On Wed, 16 Mar 2011 18:48:50 +0900, Itaru Kitayama wrote:
> > Hi Miao,
> >
> > The V4 still hangs. Does the new function, btrfs_update_inode_nodelayed() you introduced to the V4
> > need take care of a delayed node (commit delayed items of the inode and set the delayed note to NULL)?
>
> I think there no delayed item because we commit all the delayed items when we start committing
> transaction.
>
> >
> > Below is my experimental patch on top of V4 trying to avoid taking trans_mutex in btrfs_remove_delayed_node(),
> > but still hangs. Could you take a look at it? Thanks.
>
> It is so strange I can not reproduce it on my machine. But by reviewing the code, I think some inodes
> may be updated when committing the transaction, it makes the filesystem hang.
Maybe this is related to the free space cache? Is one of you using
mount -o space_cache?
-chris
next prev parent reply other threads:[~2011-03-16 17:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 15:03 [PATCH V3] btrfs: implement delayed inode items operation Itaru Kitayama
2011-03-10 6:21 ` Miao Xie
2011-03-16 9:48 ` Itaru Kitayama
2011-03-16 14:24 ` Miao Xie
2011-03-16 17:49 ` Chris Mason [this message]
2011-03-17 1:37 ` Itaru Kitayama
2011-03-18 3:37 ` Miao Xie
2011-03-18 8:59 ` Itaru Kitayama
2011-03-18 9:18 ` Miao Xie
-- strict thread matches above, loose matches on Subject: below --
2011-03-03 6:06 Miao Xie
2011-03-05 7:01 ` Itaru Kitayama
2011-03-06 23:25 ` Tsutomu Itoh
2011-03-07 1:57 ` Miao Xie
2011-03-10 3:07 ` Itaru Kitayama
2011-03-08 16:56 ` David Sterba
2011-03-09 5:40 ` Miao Xie
2011-03-11 15:24 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300297740-sup-2597@think \
--to=chris.mason@oracle.com \
--cc=kitayama@cl.bb4u.ne.jp \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.