All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: jpirko@redhat.com, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, netfilter-devel@vger.kernel.org,
	eric.dumazet@gmail.com, linville@tuxdriver.com, kaber@trash.net
Subject: Re: net-next-2.6 status...
Date: Wed, 16 Mar 2011 18:13:39 +0000	[thread overview]
Message-ID: <1300299219.2811.7.camel@bwh-desktop> (raw)
In-Reply-To: <20110316.104236.104065822.davem@davemloft.net>

On Wed, 2011-03-16 at 10:42 -0700, David Miller wrote:
> From: Jiri Pirko <jpirko@redhat.com>
> Date: Wed, 16 Mar 2011 09:40:23 +0100
> 
> > Wed, Mar 16, 2011 at 08:38:03AM CET, jpirko@redhat.com wrote:
> >>Wed, Mar 16, 2011 at 08:02:51AM CET, davem@davemloft.net wrote:
> >>>From: Jiri Pirko <jpirko@redhat.com>
> >>>Date: Wed, 16 Mar 2011 07:50:09 +0100
> >>>
> >>>>>Jiri, I know there is your patch set there, but I think you and Changli
> >>>>>still need to go back and forth one more time wrt. orig_dev semantics.
> >>>>>Since you have been posting this patch set for some time I'm still
> >>>>>willing to apply it for this merge window, but please make haste and
> >>>>>work out the remaining discussion.  Thank you.
> >>>> 
> >>>> Dave, you can apply the rest of the series and leave only the first
> >>>> patch (af_packet) out. There's no dependency. We will figure out things
> >>>> around origdev later.
> >>>
> >>>I was about to do that but I've found other problems.
> >>>
> >>>You cannot make the modifications you make to linux/if.h, those
> >>>interface flags are visible to userspace.
> >>
> >>What do you suggest? To remove unused flags and leave gaps there or to
> >>not to remove the flags at all?
> > 
> > Well, the following comment:
> > <quote>
> > /* Private (from user) interface flags (netdevice->priv_flags). */
> > </quote>
> > leads me to think that these flags should not be used by userspace.
> > So maybe it may not be problem to change those values.
> 
> Comments don't block user applications from using defines we expose
> to them.  The person who was wise enough to write that comment should
> have also been wise enough to add appropriate __KERNEL__ protection
> to the definitions.

Though, in this case, the priv_flags are not in any way visible to
user-space, so it would be quite hard to find a use for them!

> They were not, therefore we are stuck with them forever.

So should we also expose struct net_device_stats again?  During the
introduction to 64-bit stats I changed and un-exported the definition,
then later had to revert the definition but left it un-exported.  This
broke compilation of iproute2, though in the process it revealed an
existing bug: <http://thread.gmane.org/gmane.linux.network/169764>.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  reply	other threads:[~2011-03-16 18:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-15 23:01 net-next-2.6 status David Miller
2011-03-16  0:13 ` John W. Linville
2011-03-16  0:13   ` John W. Linville
2011-03-16  0:36 ` Jeff Kirsher
2011-03-16  6:50 ` Jiri Pirko
2011-03-16  7:02   ` David Miller
2011-03-16  7:38     ` Jiri Pirko
2011-03-16  8:40       ` Jiri Pirko
2011-03-16  8:40         ` Jiri Pirko
2011-03-16  8:47         ` Thomas Graf
2011-03-16 17:38           ` David Miller
2011-03-16 17:38             ` David Miller
2011-03-16 17:42         ` David Miller
2011-03-16 18:13           ` Ben Hutchings [this message]
2011-03-16 18:17             ` David Miller
2011-03-16 17:38       ` David Miller
2011-03-16 17:38         ` David Miller
2011-03-16 17:56         ` Jiri Pirko
2011-03-16 17:56           ` Jiri Pirko
2011-03-16 18:00           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300299219.2811.7.camel@bwh-desktop \
    --to=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jpirko@redhat.com \
    --cc=kaber@trash.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.