From: Namhyung Kim <namhyung@gmail.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
git@vger.kernel.org
Subject: Re: [PATCH] find_unique_abbrev(): honor caller-supplied "len" better
Date: Sun, 20 Mar 2011 01:24:33 +0900 [thread overview]
Message-ID: <1300551873.1462.8.camel@leonhard> (raw)
In-Reply-To: <AANLkTimH6ZKkTZ0MiJWzHpZywSy6Hk3caLQ5S+rE0uqg@mail.gmail.com>
2011-03-18 (금), 21:22 -0400, Jay Soffian:
> On Fri, Mar 11, 2011 at 5:45 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > +core.abbrevLength::
> > + Set the length object names are abbreviated to. If unspecified,
> > + many commands abbreviate to 7 hexdigits, which may not be enough
> > + for abbreviated object names to stay unique for sufficiently long
> > + time.
> > +
>
> Isn't this the minimum length though? i.e. a longer length is used as
> needed for uniqueness. If so, at least the description is misleading,
> and I'd argue the option name too. Perhaps core.abbrevMinLength?
>
> j.
It could confuse what it points is the default length or the minimum.
I'd like to suggest core.defaultAbbrev or core.abbrevDefault.
--
Regards,
Namhyung Kim
next prev parent reply other threads:[~2011-03-19 16:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 4:52 [GIT PULL] ext4 update for 2.6.37 Theodore Ts'o
2010-10-28 4:52 ` Theodore Ts'o
2010-10-28 7:50 ` Markus Trippelsdorf
2010-10-28 7:56 ` -tip: origin tree build failure (was: [GIT PULL] ext4 update for 2.6.37) Ingo Molnar
2010-10-28 7:56 ` Ingo Molnar
2010-10-28 12:12 ` Theodore Tso
2010-10-28 12:12 ` Theodore Tso
2010-10-28 16:30 ` Linus Torvalds
2010-10-28 16:38 ` Ingo Molnar
2010-10-28 16:55 ` Ted Ts'o
2010-10-28 17:00 ` Linus Torvalds
2010-10-28 17:17 ` Ingo Molnar
2010-10-28 17:17 ` Ingo Molnar
2010-10-28 17:27 ` Minimum git commit abbrev length (Was Re: -tip: origin tree build failure (was: [GIT PULL] ext4 update) " Ted Ts'o
2010-10-28 18:28 ` Linus Torvalds
2010-10-28 18:54 ` Linus Torvalds
2010-10-29 0:14 ` Minimum git commit abbrev length (Was Re: -tip: origin tree build failure Brandon Casey
2010-10-28 21:39 ` Junio C Hamano
2010-10-28 21:50 ` Linus Torvalds
2010-10-28 21:50 ` Linus Torvalds
2011-03-10 22:37 ` [PATCH] find_unique_abbrev(): honor caller-supplied "len" better Junio C Hamano
2011-03-10 23:07 ` Linus Torvalds
2011-03-11 0:40 ` Junio C Hamano
2011-03-11 1:16 ` Linus Torvalds
2011-03-11 1:33 ` Junio C Hamano
2011-03-11 2:21 ` Linus Torvalds
2011-03-11 3:09 ` Junio C Hamano
2011-03-11 3:03 ` Junio C Hamano
2011-03-11 5:22 ` Jeff King
2011-03-11 5:33 ` Jeff King
2011-03-11 22:45 ` Junio C Hamano
2011-03-13 13:30 ` Namhyung Kim
2011-03-19 1:22 ` Jay Soffian
2011-03-19 16:24 ` Namhyung Kim [this message]
2010-11-01 16:34 ` ext3 patches related to uninitialized memory references Roman Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300551873.1462.8.camel@leonhard \
--to=namhyung@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaysoffian@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.