[refpolicy] restorecon needs to read bin_t symlinks

[guido@trentalancia.com (Guido Trentalancia)]

On Sat, 19/03/2011 at 16.51 +0100, Dominick Grift wrote:
> On 03/19/2011 04:45 PM, Guido Trentalancia wrote:
> > Hello !
> > 
> > I have recently started to experience AVC denials due to restorecon
> > trying to read bin_t symbolic links. It is not entirely clear to me what
> > is triggering this, since everything has been working fine for a long
> > time.
> > 
> > In any case, I had to apply the following patch on my system (and I am
> > still asking myself why not files_read_all_symlinks then ?):
> > 
> > diff -pruN refpolicy-git-17032011/policy/modules/kernel/files.if refpolicy-git-17032011-restorecon/policy/modules/kernel/files.if
> > --- refpolicy-git-17032011/policy/modules/kernel/files.if	2011-02-22 18:50:44.460551925 +0100
> > +++ refpolicy-git-17032011-restorecon/policy/modules/kernel/files.if	2011-03-19 16:21:01.701636861 +0100
> > @@ -4425,7 +4425,28 @@ interface(`files_relabelfrom_usr_files',
> >  
> >  ########################################
> >  ## <summary>
> > -##	Read symbolic links in /usr.
> > +##	Read symbolic links with type
> > +##	bin_t (usually located in /bin,
> > +##	/sbin, /usr/bin and /usr/sbin).
> > +## </summary>
> > +## <param name="domain">
> > +##	<summary>
> > +##	Domain allowed access.
> > +##	</summary>
> > +## </param>
> > +#
> > +interface(`files_read_bin_symlinks',`
> 
> This interface is already available in corecommands module:
> 
> corecmd_read_bin_symlinks()
> 
> can you enclose the AVC denial that you were seeing?
> 
> It is probably this:
> 
> ls -alZ /sbin/restorecon
> lrwxrwxrwx. root root system_u:object_r:bin_t:s0       /sbin/restorecon
> - -> setfiles

Yes, apart from the duplicate interface, the restorecon symbolic link is
created by the original Makefile from policycoreutils. It's fine to me
if setfiles is just copied off instead of linked.

Regards,

Guido