All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Brown <jeffbrown@android.com>
To: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jeff Brown <jeffbrown@google.com>,
	jeffbrown@android.com
Subject: [PATCH 3/4] input: evdev: Indicate buffer overrun with SYN_DROPPED.
Date: Tue, 22 Mar 2011 18:04:03 -0700	[thread overview]
Message-ID: <1300842244-42723-4-git-send-email-jeffbrown@android.com> (raw)
In-Reply-To: <1300842244-42723-1-git-send-email-jeffbrown@android.com>

From: Jeff Brown <jeffbrown@google.com>

Add a new EV_SYN code, SYN_DROPPED, to inform the client when input
events have been dropped from the evdev input buffer due to a
buffer overrun.  The client should use this event as a hint to
reset its state or ignore all following events until the next
packet begins.

Signed-off-by: jeffbrown@android.com
---
 drivers/input/evdev.c |   18 ++++++++++++------
 include/linux/input.h |    1 +
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index 7f42d3a..203ed70 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -57,14 +57,20 @@ static void evdev_pass_event(struct evdev_client *client,
 {
 	/*
 	 * Interrupts are disabled, just acquire the lock.
-	 * Make sure we don't leave with the client buffer
-	 * "empty" by having client->head == client->tail.
+	 * When the client buffer is full, replace the tail with SYN_DROPPED
+	 * to let the client know that events were dropped.  Ensure that the
+	 * head and tail never coincide so the buffer does not appear "empty".
 	 */
 	spin_lock(&client->buffer_lock);
-	do {
-		client->buffer[client->head++] = *event;
-		client->head &= client->bufsize - 1;
-	} while (client->head == client->tail);
+	client->buffer[client->head++] = *event;
+	client->head &= client->bufsize - 1;
+	if (client->head == client->tail) {
+		client->tail = (client->tail + 1) & (client->bufsize - 1);
+		client->buffer[client->tail].time = event->time;
+		client->buffer[client->tail].type = EV_SYN;
+		client->buffer[client->tail].code = SYN_DROPPED;
+		client->buffer[client->tail].value = 0;
+	}
 	spin_unlock(&client->buffer_lock);
 
 	if (event->type == EV_SYN)
diff --git a/include/linux/input.h b/include/linux/input.h
index 056ae8a..65d253e 100644
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -167,6 +167,7 @@ struct input_keymap_entry {
 #define SYN_REPORT		0
 #define SYN_CONFIG		1
 #define SYN_MT_REPORT		2
+#define SYN_DROPPED		3
 
 /*
  * Keys and buttons
-- 
1.7.0.4

  parent reply	other threads:[~2011-03-23  1:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23  1:04 [PATCH 0/4] input: Sizing the evdev ring buffer for MT devices and reporting overruns Jeff Brown
2011-03-23  1:04 ` [PATCH 1/4] input: Set default events per packet Jeff Brown
2011-03-25  8:20   ` Henrik Rydberg
2011-03-25 23:30     ` Jeffrey Brown
2011-03-25 23:30       ` Jeffrey Brown
2011-03-28  7:10       ` Henrik Rydberg
2011-03-23  1:04 ` [PATCH 2/4] hid: hid-input: Remove obsolete default events per packet setting Jeff Brown
2011-03-23  1:04 ` Jeff Brown [this message]
2011-03-25  7:47   ` [PATCH 3/4] input: evdev: Indicate buffer overrun with SYN_DROPPED Dmitry Torokhov
2011-03-25  8:14   ` Henrik Rydberg
2011-03-25  9:02   ` Henrik Rydberg
     [not found]     ` <AANLkTike4c7SaeAm5JVWcLyZYt1K59OUEk94rnPeRkMy@mail.gmail.com>
2011-03-25 23:10       ` Jeffrey Brown
2011-03-25 23:12     ` Jeffrey Brown
2011-03-25 23:12       ` Jeffrey Brown
2011-03-23  1:04 ` [PATCH 4/4] input: evdev: only wake poll on EV_SYN Jeff Brown
2011-03-25  7:49   ` Dmitry Torokhov
2011-03-25 23:03     ` Jeffrey Brown
2011-03-25 23:03       ` Jeffrey Brown
2011-03-28  6:12       ` Dmitry Torokhov
2011-03-28  6:12         ` Dmitry Torokhov
2011-03-28  8:54         ` Jeffrey Brown
2011-03-28  8:54           ` Jeffrey Brown
2011-03-25  8:34   ` Henrik Rydberg
2011-03-25 23:07     ` Jeffrey Brown
2011-03-25 23:07       ` Jeffrey Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300842244-42723-4-git-send-email-jeffbrown@android.com \
    --to=jeffbrown@android.com \
    --cc=jeffbrown@google.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.