From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932366Ab1CWJf5 (ORCPT ); Wed, 23 Mar 2011 05:35:57 -0400 Received: from darkcity.gna.ch ([195.226.6.51]:47195 "EHLO mail.gna.ch" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932307Ab1CWJfz convert rfc822-to-8bit (ORCPT ); Wed, 23 Mar 2011 05:35:55 -0400 X-Amavis-Alert: BAD HEADER SECTION, Improper folded header field made up entirely of whitespace (char 09 hex): Face: ...MWASAkVVViQjzP\n jycPrvgA\n\t\n R1goSzOnkp14Y[...] Subject: Re: [git pull] drm fixes From: Michel =?ISO-8859-1?Q?D=E4nzer?= To: Dave Airlie Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, DRI mailing list In-Reply-To: References: <1300864998.3522.71.camel@thor.local> <1300868532.3522.81.camel@thor.local> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAADBQTFRFDg4OHh4eLCwsOzs7S0tLWlpaa2treXl5hISEjY2NmJiYqKiotLS0xsbG1dXV/Pz81CO0SQAAArtJREFUOMtd1M9P01AcAHCI/4AtGq/QDfDHRfraEX8eaNeJFw1rO/DCYet7mxc1ZG0x3sStHQkmZpqtHDwAi+tMiFEzbZdwNWEJR48cjPG4g5HhELUbrHvjpYe2n7zvt++977cD/7rjsCry8uNG93Gge9OKUyAAgLB1AlpTZICmAzR15QTEiQAPAKADYLMPfhNnEJR4HvD0tT5YI2KGUcyqihQN7mDwZ3hMN4q2N4ol+gEGTSLWhorrjYXrGPwc0jTDOoKP4xi8G0W6adl2Gz6zGDwag5p5PMON7vZgJuSB976+3U6y2QdeKNet1+uum9/qwVQHvEjtKesY0EIb7CNYe+7DIRXCID/vQ4tksVAY7JFBD7yvqrWTL93xoUmOQsPIddbnuk8v+bBPsigB2KRlFxS4nL/owwEpKBSg2MU3UcDf+nATyyHEQwrHzJZFNpXeuOHDC0qW4sMhEHESFGOUrvgQpWUYFVNQdjQxca8abnSB55CmehdcLSxa1ifoQ4JBpmGYWbhsly3X0fxQ7xmkW3Y5CztLcXI+fAu2oWho3nbV6s5rH35xSC/aBR2tOpVa/Utv25tcTDPL6aT21kG17WrvaFtMBJmFhJCsVF4uu9VG76DWBaRnEiNs7pU659pYlfwtQSRy9GCYlwR7C6/dPQgBw3MsTPNWA4d9SeMDDC9JYdnqq/amdF+diGnVhXFztQ/2lJSWjulOxjRX+uC7EkOqhLRk2ejrqHVBEqCqJLO5cmEXgx8TrBiWVQh1u2DhzQlPsyIveU2YLGorGBxODoR5notlpcUieoLB1/NEmGc4AalGJpLe8WF/8txMWASAkVVViQjzP jycPrvgA R1goSzOnkp14YCYHsp7QJHAS5QcXDqG1jBxdSITVgBNkBTFloj88Q/gMkFcuItYiQPUCBGc2xh5drsD/wGZrgsgDOE4ZAAAAABJRU5ErkJggg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Wed, 23 Mar 2011 10:35:19 +0100 Message-ID: <1300872919.16522.10.camel@thor.local> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mit, 2011-03-23 at 19:06 +1000, Dave Airlie wrote: > 2011/3/23 Michel Dänzer : > > On Mit, 2011-03-23 at 18:16 +1000, Dave Airlie wrote: > >> 2011/3/23 Michel Dänzer : > >> > On Mit, 2011-03-23 at 04:18 +0000, Dave Airlie wrote: > >> >> > >> >> One radeon, 2 core fixes, and an interface update to allow for > 2 crtcs > >> >> in vblank. > >> > > >> > [...] > >> > > >> >> Ilija Hadzic (1): > >> >> drm/kernel: vblank wait on crtc > 1 > >> > > >> > This patch was still being debated yesterday, are you deliberately > >> > pushing it regardless? Once it hits mainline, it'll be pretty much set > >> > in stone. > >> > >> From what I can see it was the userspace patches being debated, this > >> one seemed fine and the interface looked okay to me. > > > > The author ignored my suggestions to make the patch smaller and simpler, > > more maintainable and more future-proof all at once. > > It was already small and I'm not sure merging the flags made it more > maintainable. Having two holes between _DRM_VBLANK_FLAGS_MASK, _DRM_VBLANK_HIGH_CRTC_MASK and _DRM_VBLANK_TYPES_MASK can unnecessarily complicate future extensions. > Its always being a slightly painful ioctl, and hopefully any future > changes add a new ioctl esp if we want 64-bit values. Is there really a problem with assuming that if the 32-bit value went backwards, the upper 32 bits have incremented by 1? 1 << 32 refreshes is about 2 years, so I can't really see any ambiguity there. For hardware that doesn't have 64 bit frame counters (does any have that yet?), something like that needs to be done at some level anyway. Anyway, that's another discussion... -- Earthling Michel Dänzer | http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel =?ISO-8859-1?Q?D=E4nzer?= Subject: Re: [git pull] drm fixes Date: Wed, 23 Mar 2011 10:35:19 +0100 Message-ID: <1300872919.16522.10.camel@thor.local> References: <1300864998.3522.71.camel@thor.local> <1300868532.3522.81.camel@thor.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BD6D9E73D for ; Wed, 23 Mar 2011 02:35:53 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: DRI@freedesktop.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mailing list List-Id: dri-devel@lists.freedesktop.org T24gTWl0LCAyMDExLTAzLTIzIGF0IDE5OjA2ICsxMDAwLCBEYXZlIEFpcmxpZSB3cm90ZTogCj4g MjAxMS8zLzIzIE1pY2hlbCBEw6RuemVyIDxtaWNoZWxAZGFlbnplci5uZXQ+Ogo+ID4gT24gTWl0 LCAyMDExLTAzLTIzIGF0IDE4OjE2ICsxMDAwLCBEYXZlIEFpcmxpZSB3cm90ZToKPiA+PiAyMDEx LzMvMjMgTWljaGVsIETDpG56ZXIgPG1pY2hlbEBkYWVuemVyLm5ldD46Cj4gPj4gPiBPbiBNaXQs IDIwMTEtMDMtMjMgYXQgMDQ6MTggKzAwMDAsIERhdmUgQWlybGllIHdyb3RlOgo+ID4+ID4+Cj4g Pj4gPj4gT25lIHJhZGVvbiwgMiBjb3JlIGZpeGVzLCBhbmQgYW4gaW50ZXJmYWNlIHVwZGF0ZSB0 byBhbGxvdyBmb3IgPiAyIGNydGNzCj4gPj4gPj4gaW4gdmJsYW5rLgo+ID4+ID4KPiA+PiA+IFsu Li5dCj4gPj4gPgo+ID4+ID4+IElsaWphIEhhZHppYyAoMSk6Cj4gPj4gPj4gICAgICAgZHJtL2tl cm5lbDogdmJsYW5rIHdhaXQgb24gY3J0YyA+IDEKPiA+PiA+Cj4gPj4gPiBUaGlzIHBhdGNoIHdh cyBzdGlsbCBiZWluZyBkZWJhdGVkIHllc3RlcmRheSwgYXJlIHlvdSBkZWxpYmVyYXRlbHkKPiA+ PiA+IHB1c2hpbmcgaXQgcmVnYXJkbGVzcz8gT25jZSBpdCBoaXRzIG1haW5saW5lLCBpdCdsbCBi ZSBwcmV0dHkgbXVjaCBzZXQKPiA+PiA+IGluIHN0b25lLgo+ID4+Cj4gPj4gRnJvbSB3aGF0IEkg Y2FuIHNlZSBpdCB3YXMgdGhlIHVzZXJzcGFjZSBwYXRjaGVzIGJlaW5nIGRlYmF0ZWQsIHRoaXMK PiA+PiBvbmUgc2VlbWVkIGZpbmUgYW5kIHRoZSBpbnRlcmZhY2UgbG9va2VkIG9rYXkgdG8gbWUu Cj4gPgo+ID4gVGhlIGF1dGhvciBpZ25vcmVkIG15IHN1Z2dlc3Rpb25zIHRvIG1ha2UgdGhlIHBh dGNoIHNtYWxsZXIgYW5kIHNpbXBsZXIsCj4gPiBtb3JlIG1haW50YWluYWJsZSBhbmQgbW9yZSBm dXR1cmUtcHJvb2YgYWxsIGF0IG9uY2UuCj4gCj4gSXQgd2FzIGFscmVhZHkgc21hbGwgYW5kIEkn bSBub3Qgc3VyZSBtZXJnaW5nIHRoZSBmbGFncyBtYWRlIGl0IG1vcmUKPiBtYWludGFpbmFibGUu CgpIYXZpbmcgdHdvIGhvbGVzIGJldHdlZW4gX0RSTV9WQkxBTktfRkxBR1NfTUFTSywKX0RSTV9W QkxBTktfSElHSF9DUlRDX01BU0sgYW5kIF9EUk1fVkJMQU5LX1RZUEVTX01BU0sgY2FuIHVubmVj ZXNzYXJpbHkKY29tcGxpY2F0ZSBmdXR1cmUgZXh0ZW5zaW9ucy4KCgo+IEl0cyBhbHdheXMgYmVp bmcgYSBzbGlnaHRseSBwYWluZnVsIGlvY3RsLCBhbmQgaG9wZWZ1bGx5IGFueSBmdXR1cmUKPiBj aGFuZ2VzIGFkZCBhIG5ldyBpb2N0bCBlc3AgaWYgd2Ugd2FudCA2NC1iaXQgdmFsdWVzLgoKSXMg dGhlcmUgcmVhbGx5IGEgcHJvYmxlbSB3aXRoIGFzc3VtaW5nIHRoYXQgaWYgdGhlIDMyLWJpdCB2 YWx1ZSB3ZW50CmJhY2t3YXJkcywgdGhlIHVwcGVyIDMyIGJpdHMgaGF2ZSBpbmNyZW1lbnRlZCBi eSAxPyAxIDw8IDMyIHJlZnJlc2hlcyBpcwphYm91dCAyIHllYXJzLCBzbyBJIGNhbid0IHJlYWxs eSBzZWUgYW55IGFtYmlndWl0eSB0aGVyZS4gRm9yIGhhcmR3YXJlCnRoYXQgZG9lc24ndCBoYXZl IDY0IGJpdCBmcmFtZSBjb3VudGVycyAoZG9lcyBhbnkgaGF2ZSB0aGF0IHlldD8pLApzb21ldGhp bmcgbGlrZSB0aGF0IG5lZWRzIHRvIGJlIGRvbmUgYXQgc29tZSBsZXZlbCBhbnl3YXkuCgpBbnl3 YXksIHRoYXQncyBhbm90aGVyIGRpc2N1c3Npb24uLi4KCgotLSAKRWFydGhsaW5nIE1pY2hlbCBE w6RuemVyICAgICAgICAgICB8ICAgICAgICAgICAgICAgIGh0dHA6Ly93d3cudm13YXJlLmNvbQpM aWJyZSBzb2Z0d2FyZSBlbnRodXNpYXN0ICAgICAgICAgfCAgICAgICAgICBEZWJpYW4sIFggYW5k IERSSSBkZXZlbG9wZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK