From: Artem Bityutskiy <dedekind1@gmail.com>
To: Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: linux-mtd@lists.infradead.org, adrian.hunter@nokia.com
Subject: Re: [PATCH 1/1] ubifs: debugfs operations may return both ERRs and NULLs
Date: Wed, 23 Mar 2011 14:41:56 +0200 [thread overview]
Message-ID: <1300884116.2735.45.camel@localhost> (raw)
In-Reply-To: <1300873889-18336-1-git-send-email-ext-phil.2.carmody@nokia.com>
On Wed, 2011-03-23 at 11:51 +0200, Phil Carmody wrote:
> I knew I invented IS_ERR_OR_NULL for something, and this was probably
> it. NULL has lost all information about what the error was, and the most
> appropriate error code is ENODEV. However, that's the only error code
> that the debugfs functions can return. So basically, any error = ENODEV.
>
> Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
The debugfs code may change and gain more error codes, so I do not think
it is good idea to treat any error as ENODEV. I think only NULL should
be translated to ENODEV instead.
I'll try to re-work your patch accordingly and push it unless you send a
new one.
Thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-03-23 12:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 9:51 [PATCH 1/1] ubifs: debugfs operations may return both ERRs and NULLs Phil Carmody
2011-03-23 12:41 ` Artem Bityutskiy [this message]
2011-03-23 13:16 ` Phil Carmody
2011-03-23 13:35 ` Phil Carmody
2011-03-28 6:51 ` Artem Bityutskiy
2011-03-28 10:38 ` Phil Carmody
2011-03-28 12:10 ` Artem Bityutskiy
2011-03-23 13:18 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300884116.2735.45.camel@localhost \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@nokia.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.