All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH V2 1/1] scripts/poky-qemu-internal: Add call to stty
Date: Wed, 23 Mar 2011 16:53:52 +0000	[thread overview]
Message-ID: <1300899232.3018.31.camel@rex> (raw)
In-Reply-To: <2a46643e032d11e07f6dfec471cadea8e9dba827.1300732395.git.raj.khem@gmail.com>

On Mon, 2011-03-21 at 11:34 -0700, Khem Raj wrote:
> When qemu is booted into console with -nographics
> then after exiting the terminal line settings are messed
> up. This patch calls stty sane to restore the terminal
> settings to default.
> 
> stty is part of coreutils which is installed on all
> host distros hence there is no need to warn about it
> being available or not
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  scripts/poky-qemu-internal |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/poky-qemu-internal b/scripts/poky-qemu-internal
> index 8fd1834..556ce69 100755
> --- a/scripts/poky-qemu-internal
> +++ b/scripts/poky-qemu-internal
> @@ -189,6 +189,7 @@ cleanup() {
>          echo "poky-export-rootfs stop $ROOTFS"
>          poky-export-rootfs stop $ROOTFS
>      fi
> +    stty sane
>  }
>  
>  n1=$[ (`echo $TAP | sed 's/tap//'` * 2) + 1 ]

With the recent change to the script to run:

$QEMUBIN -kernel $KERNEL $QEMUOPTIONS $SERIALOPTS -no-reboot $SCRIPT_QEMU_OPT $SCRIPT_QEMU_EXTRA_OPT --append "$KERNCMDLINE $SCRIPT_KERNEL_OPT" || stty sane

is the above change still needed?

Cheers,

Richard




  reply	other threads:[~2011-03-23 16:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21 18:34 [PATCH V2 0/1] Call stty sane before exiting qemu Khem Raj
2011-03-21 18:34 ` [PATCH V2 1/1] scripts/poky-qemu-internal: Add call to stty Khem Raj
2011-03-23 16:53   ` Richard Purdie [this message]
2011-03-23 18:13     ` Khem Raj
2011-03-25 13:34       ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300899232.3018.31.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.