From: George Dunlap <george.dunlap@eu.citrix.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: Olaf Hering <olaf@aepfle.de>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 5 of 5] xentrace: use consistent printk prefix
Date: Wed, 23 Mar 2011 17:02:40 +0000 [thread overview]
Message-ID: <1300899760.2827.33.camel@silas> (raw)
In-Reply-To: <4D8A2BFA0200007800037F22@vpn.id2.novell.com>
On Wed, 2011-03-23 at 16:20 +0000, Jan Beulich wrote:
> >>> On 23.03.11 at 15:47, George Dunlap <george.dunlap@eu.citrix.com> wrote:
> > I'd prefer something a tiny bit more descriptive, like "xentrace:", but
> > I would acquiesce to xtb if someone felt strongly about it.
>
> I was nagging just because "Xen trace buffers: " seemed overly long
> to me. I'm fine with your preference.
I agree that "Xen trace buffers" is too long -- debug output on a serial
line is somewhat precious when your machine is crashing. :-)
Olaf, are you OK with making the prefix consistently "xentrace"?
-George
>
> Jan
>
> > -George
> >
> > On Wed, 2011-03-23 at 11:18 +0000, Olaf Hering wrote:
> >> On Wed, Mar 23, Jan Beulich wrote:
> >>
> >> > >>> On 22.03.11 at 20:21, Olaf Hering <olaf@aepfle.de> wrote:
> >> > > # HG changeset patch
> >> > > # User Olaf Hering <olaf@aepfle.de>
> >> > > # Date 1300813820 -3600
> >> > > # Node ID dcbae547cce81f10c243d54bd35fd139615313cb
> >> > > # Parent e58f6949e76a2786c4f5a99a0da44ee58743b4df
> >> > > xentrace: use consistent printk prefix
> >> >
> >> > Why "Xen trace buffers: " and not e.g. "xtb: "?
> >>
> >> Its used in other printk calls already.
> >> George, would a change to xtb: be ok for you for all existing printk calls?
> >>
> >> Olaf
>
>
>
next prev parent reply other threads:[~2011-03-23 17:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 19:21 [PATCH 0 of 5] xentrace updates Olaf Hering
2011-03-22 19:21 ` [PATCH 1 of 5] xentrace: fix t_info_pages calculation for the default case Olaf Hering
2011-03-23 10:12 ` Jan Beulich
2011-03-23 10:22 ` Keir Fraser
2011-03-23 11:20 ` Olaf Hering
2011-03-23 12:33 ` Keir Fraser
2011-03-23 12:46 ` Olaf Hering
2011-03-23 14:56 ` George Dunlap
2011-03-23 12:45 ` Jan Beulich
2011-03-23 13:16 ` Olaf Hering
2011-03-23 13:35 ` Keir Fraser
2011-03-22 19:21 ` [PATCH 2 of 5] xentrace: print calculated numbers in calculate_tbuf_size() Olaf Hering
2011-03-22 19:21 ` [PATCH 3 of 5] xentrace: remove gdprintk usage since they are not in guest context Olaf Hering
2011-03-22 19:21 ` [PATCH 4 of 5] xentrace: update comments Olaf Hering
2011-03-22 19:21 ` [PATCH 5 of 5] xentrace: use consistent printk prefix Olaf Hering
2011-03-23 10:14 ` Jan Beulich
2011-03-23 11:18 ` Olaf Hering
2011-03-23 14:47 ` George Dunlap
2011-03-23 16:20 ` Jan Beulich
2011-03-23 17:02 ` George Dunlap [this message]
2011-03-23 17:11 ` Olaf Hering
-- strict thread matches above, loose matches on Subject: below --
2011-03-23 17:54 [PATCH 0 of 5] xentrace updates Olaf Hering
2011-03-23 17:54 ` [PATCH 5 of 5] xentrace: use consistent printk prefix Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300899760.2827.33.camel@silas \
--to=george.dunlap@eu.citrix.com \
--cc=JBeulich@novell.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.