From: Thomas Monjalon <thomas@monjalon.net>
To: Shahaf Shuler <shahafs@mellanox.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure
Date: Tue, 19 Nov 2019 10:32:42 +0100 [thread overview]
Message-ID: <13010452.zfGL6P0G4r@xps> (raw)
In-Reply-To: <20191118100247.74241-1-shahafs@mellanox.com>
18/11/2019 11:02, Shahaf Shuler:
> struct rte_pktmbuf_pool_private {
> uint16_t mbuf_data_room_size; /**< Size of data space in each mbuf. */
> uint16_t mbuf_priv_size; /**< Size of private area in each mbuf. */
> + uint32_t reserved; /**< reserved for future use. */
Maybe simpler to give the future name "flags" and keep the comment
"reserved for future use".
Olivier, what do you think?
next prev parent reply other threads:[~2019-11-19 9:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 10:02 [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure Shahaf Shuler
2019-11-18 16:12 ` Stephen Hemminger
2019-11-19 6:35 ` Shahaf Shuler
2019-11-19 9:32 ` Thomas Monjalon [this message]
2019-11-19 15:23 ` Shahaf Shuler
2019-11-19 16:25 ` Stephen Hemminger
2019-11-19 22:30 ` Thomas Monjalon
2019-11-19 23:50 ` Stephen Hemminger
2019-11-20 7:01 ` Shahaf Shuler
2019-11-20 15:56 ` Stephen Hemminger
2019-11-21 14:15 ` Olivier Matz
2019-11-21 12:28 ` [dpdk-dev] [PATCH v2] " Shahaf Shuler
2019-11-21 14:31 ` Olivier Matz
2019-11-24 5:52 ` Shahaf Shuler
2019-11-24 5:53 ` [dpdk-dev] [PATCH v3] " Shahaf Shuler
2019-11-24 17:50 ` Stephen Hemminger
2019-11-24 18:05 ` Thomas Monjalon
2019-11-24 18:10 ` Shahaf Shuler
2019-11-25 8:12 ` Olivier Matz
2019-11-25 10:21 ` [dpdk-dev] [PATCH v4] " Shahaf Shuler
2019-11-25 10:27 ` Olivier Matz
2019-11-25 21:42 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13010452.zfGL6P0G4r@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.