From: Igor Plyatov <plyatov@gmail.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: pata_at91.c bugfix for initial_timing initialisation
Date: Mon, 28 Mar 2011 17:01:15 +0400 [thread overview]
Message-ID: <1301317275.29670.3.camel@homepc> (raw)
In-Reply-To: <4D906C40.6040104@ru.mvista.com>
Dear Sergei and Eric,
It's so stupid from my side to send broken patch, but it happens :-)
Please, look at new my e-mails with subjects:
* "[PATCH v4 1/2] ata: pata_at91.c bugfix for initial_timing
initialisation"
* "[PATCH v4 2/2] ata: pata_at91.c bugfix for high master clock"
Best regards!
--
Igor Plyatov
> Hello.
>
> Igor Plyatov wrote:
>
> > The "struct ata_timing" must contain 10 members, but ".dmack_hold" member was
> > forgotten for "initial_timing" initialisation. This patch fixes such a problem.
>
> > Signed-off-by: Igor Plyatov <plyatov@gmail.com>
> > ---
> > drivers/ata/pata_at91.c | 5 +++--
> > 1 files changed, 3 insertions(+), 2 deletions(-)
>
> > diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
> > index 0da0dcc..d1aaeb5 100644
> > --- a/drivers/ata/pata_at91.c
> > +++ b/drivers/ata/pata_at91.c
> > @@ -49,8 +49,9 @@ struct at91_ide_info {
> > void __iomem *alt_addr;
> > };
> >
> > -static const struct ata_timing initial_timing =
> > - {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0};
> > +static const struct ata_timing initial_timing = {
> > + XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0
> > +};
>
> Frankly, I don't see any difference.
>
> WBR, Sergei
next prev parent reply other threads:[~2011-03-28 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 11:59 [PATCH] ata: pata_at91.c bugfix for initial_timing initialisation Igor Plyatov
2011-03-28 11:08 ` Sergei Shtylyov
2011-03-28 13:01 ` Igor Plyatov [this message]
2011-03-28 12:09 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301317275.29670.3.camel@homepc \
--to=plyatov@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.