From: Ben Hutchings <ben@decadent.org.uk>
To: ralf@linux-mips.org
Cc: drosenberg@vsecurity.com, netdev@vger.kernel.org,
security@kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2] ROSE: prevent heap corruption with bad facilities
Date: Tue, 29 Mar 2011 02:16:19 +0100 [thread overview]
Message-ID: <1301361379.26693.742.camel@localhost> (raw)
In-Reply-To: <20110327.175936.189721420.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
On Sun, 2011-03-27 at 17:59 -0700, David Miller wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
> Date: Sun, 20 Mar 2011 16:48:05 +0000
>
> > Subject: [PATCH] rose: Add length checks to CALL_REQUEST parsing
> >
> > Define some constant offsets for CALL_REQUEST based on the description
> > at <http://www.techfest.com/networking/wan/x25plp.htm> and the
> > definition of ROSE as using 10-digit (5-byte) addresses. Use them
> > consistently. Validate all implicit and explicit facilities lengths.
> > Validate the address length byte rather than either trusting or
> > assuming its value.
> >
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>
> Applied.
Ralf, I would really appreciate it if you could test this soon...
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2011-03-29 1:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-20 6:43 [PATCH v2] ROSE: prevent heap corruption with bad facilities Dan Rosenberg
2011-03-20 16:48 ` Ben Hutchings
2011-03-28 0:59 ` David Miller
2011-03-29 1:16 ` Ben Hutchings [this message]
2011-03-29 16:26 ` Ralf Baechle
2011-03-31 18:02 ` Jiri Bohac
2011-04-01 12:29 ` Jiri Bohac
2011-04-02 4:41 ` David Miller
2011-04-05 8:20 ` Jiri Bohac
2011-04-03 4:23 ` Ben Hutchings
2011-03-28 0:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301361379.26693.742.camel@localhost \
--to=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=drosenberg@vsecurity.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.