From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [RFC PATCH 3/3] hwmon: sht15: add support for
Date: Tue, 29 Mar 2011 20:27:12 +0000 [thread overview]
Message-ID: <1301429985-sup-4779@sfl> (raw)
In-Reply-To: <1300301050-15529-4-git-send-email-vivien.didelot@savoirfairelinux.com>
Excerpts from Jean Delvare's message of 2011-03-26 17:50:31 -0400:
> I don't. Sure, the hardware default for the low nibble of the "status"
> register is 0, and the driver was leaving it untouched so far, but that
> doesn't mean that the BIOS or firmware didn't change it before the
> sht15 driver got loaded. The patch adding support for checksum
> validation should handle this case properly.
That's right. I'll switch the two patches. Firstly, the status
register support, then the CRC support.
> I guess it was difficult to find a suitable name, given that the high
> nibble of the register holds status bits and the low nibble holds
> configuration bits.
>
> > You're right. Should I rename every sht15_*_status() functions into
> > sht15_*_state()?
>
> My opinion on this (which you are free to listen to or ignore): "state"
> is hardly better than "status" to describe this register. So I would
> either stick to "status" to match the datasheet, or go for "config" to
> reflect the nature of the writable bits of the register.
I think I'll keep "status" because it won't make sense to write a
SHT15_CONFIG_BATTERY to match the battery state bit.
>
> Good night,
Regards,
Vivien.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2011-03-29 20:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 18:44 [lm-sensors] [RFC PATCH 3/3] hwmon: sht15: add support for writing Vivien Didelot
2011-03-21 19:55 ` [lm-sensors] [RFC PATCH 3/3] hwmon: sht15: add support for Jonathan Cameron
2011-03-22 0:29 ` Vivien Didelot
2011-03-22 10:34 ` Jonathan Cameron
2011-03-26 21:50 ` Jean Delvare
2011-03-29 20:27 ` Vivien Didelot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301429985-sup-4779@sfl \
--to=vivien.didelot@savoirfairelinux.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.