All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: MTD list <linux-mtd@lists.infradead.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] UBI: do not select KALLSYMS_ALL
Date: Wed, 30 Mar 2011 11:40:16 +0300	[thread overview]
Message-ID: <1301474416-8202-3-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1301474416-8202-1-git-send-email-dedekind1@gmail.com>

From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

All UBI needs is to make sure we stacktraces when UBI debugging
is enabled. It is enough to select KALLSYMS for this, KALLSYMS_ALL
is not necessary.

And the current Kconfig line we have:

select KALLSYMS_ALL if KALLSYMS && DEBUG_KERNEL

is just too complex to be sane and right. But this "if" part there
is needed to prevent "unmet direct dependency" warnings, because
KALLSYMS_ALL depends on KALLSYMS and DEBUG_KERNEL, so we cannot
just select KALLSYMS_ALL.

Anyway, this feels messy, and we do not seem to really need KALLSYMS_ALL,
so select KALLSYMS instead.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 drivers/mtd/ubi/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/ubi/Kconfig b/drivers/mtd/ubi/Kconfig
index 6abeb4f..4dcc752 100644
--- a/drivers/mtd/ubi/Kconfig
+++ b/drivers/mtd/ubi/Kconfig
@@ -56,7 +56,7 @@ config MTD_UBI_DEBUG
 	bool "UBI debugging"
 	depends on SYSFS
 	select DEBUG_FS
-	select KALLSYMS_ALL if KALLSYMS && DEBUG_KERNEL
+	select KALLSYMS
 	help
 	  This option enables UBI debugging.
 
-- 
1.7.2.3

  parent reply	other threads:[~2011-03-30  8:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-30  8:40 [PATCH 0/2] do not select KALLSYMS_ALL Artem Bityutskiy
2011-03-30  8:40 ` [PATCH 1/2] UBIFS: " Artem Bityutskiy
2011-03-30 22:41   ` Randy Dunlap
2011-03-31  6:29     ` Artem Bityutskiy
2011-03-30  8:40 ` Artem Bityutskiy [this message]
2011-03-30 22:41   ` [PATCH 2/2] UBI: " Randy Dunlap
2011-03-31 14:18 ` [PATCH 0/2] " Paulo Marques
2011-04-01 14:40   ` Artem Bityutskiy
2011-04-01 14:56   ` Artem Bityutskiy
2011-04-01 15:01     ` Artem Bityutskiy
2011-04-01 15:11       ` Ricard Wanderlof
2011-04-01 15:11         ` Ricard Wanderlof
2011-04-01 15:34       ` Paulo Marques
2011-04-01 15:42         ` Artem Bityutskiy
2011-04-01 15:54           ` Paulo Marques
2011-04-04  7:12             ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301474416-8202-3-git-send-email-dedekind1@gmail.com \
    --to=dedekind1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.