From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH 2 of 2] xen: hvm_save: Add pre-3.4
	compatibility for hvm_hw_cpu
Date: Fri, 01 Apr 2011 12:13:55 +0100
Message-ID: <1301656435.9447.79.camel@elijah>
References: <patchbomb.1301581299@elijah>
	<e2f2377fedef200932fd.1301581301@elijah>
	<1301654976.27123.207.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1301654976.27123.207.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2011-04-01 at 11:49 +0100, Ian Campbell wrote:
> On Thu, 2011-03-31 at 15:21 +0100, George Dunlap wrote:
> > @@ -46,6 +46,8 @@
> >  
> >  /*
> >   * Processor
> > + *
> > + * Compat: Pre-3.4 didn't have msr_tsc_aux
> 
> Do you mean Pre-4.0? i.e. 3.4 and earlier?

Yes, I noticed that a bit too late. :-)

> 
> >   */
> >  
> >  struct hvm_hw_cpu {
> > @@ -157,8 +159,131 @@
> >      uint32_t error_code;
> >  };
> >  
> > -DECLARE_HVM_SAVE_TYPE(CPU, 2, struct hvm_hw_cpu);
> > +struct hvm_hw_cpu_compat { 
> 
> "struct hvm_hw_cpu_3_4_compat" to make it clear which version compat is
> with?

Sounds like a good idea.  If Tim thinks it's worth including, I'll spin
up another series.

 -George