From: George Dunlap <george.dunlap@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 3 of 3] xentrace: remove unneeded debug printk
Date: Fri, 01 Apr 2011 12:18:37 +0100 [thread overview]
Message-ID: <1301656717.9447.89.camel@elijah> (raw)
In-Reply-To: <eea91e2e4b452cb57398.1301508275@localhost>
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
On Wed, 2011-03-30 at 19:04 +0100, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1301424082 -7200
> # Node ID eea91e2e4b452cb573982f4b47ecfa4c656e9547
> # Parent 3e95e737bc51c2295926e4f23389b1cb161d6d7b
> xentrace: remove unneeded debug printk
>
> The pointer value in case of an allocation failure is rather uninteresting.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> diff -r 3e95e737bc51 -r eea91e2e4b45 xen/common/trace.c
> --- a/xen/common/trace.c Tue Mar 29 20:41:15 2011 +0200
> +++ b/xen/common/trace.c Tue Mar 29 20:41:22 2011 +0200
> @@ -239,7 +239,6 @@
> {
> void *rawbuf = per_cpu(t_bufs, cpu);
> per_cpu(t_bufs, cpu) = NULL;
> - printk(XENLOG_DEBUG "xentrace: cpu %d p %p\n", cpu, rawbuf);
> if ( rawbuf )
> {
> ASSERT(!(virt_to_page(rawbuf)->count_info & PGC_allocated));
prev parent reply other threads:[~2011-04-01 11:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 18:04 [PATCH 0 of 3] xentrace updates Olaf Hering
2011-03-30 18:04 ` [PATCH 1 of 3] xentrace: correct formula to calculate t_info_pages Olaf Hering
2011-04-01 10:32 ` George Dunlap
2011-03-30 18:04 ` [PATCH 2 of 3] xentrace: use tbuf_size for overflow check Olaf Hering
2011-04-01 11:18 ` George Dunlap
2011-04-05 10:19 ` Olaf Hering
2011-04-07 13:50 ` Olaf Hering
2011-04-18 18:45 ` non-contiguous allocations Olaf Hering
2011-04-26 11:51 ` Jan Beulich
2011-05-06 10:25 ` Olaf Hering
2011-05-06 10:45 ` Jan Beulich
2011-05-06 18:12 ` Olaf Hering
2011-05-06 18:46 ` Keir Fraser
2011-05-07 8:39 ` Olaf Hering
2011-05-07 16:31 ` Keir Fraser
2011-05-09 8:30 ` Jan Beulich
2011-05-09 8:34 ` Keir Fraser
2011-05-09 12:43 ` Olaf Hering
2011-05-09 14:14 ` Keir Fraser
2011-03-30 18:04 ` [PATCH 3 of 3] xentrace: remove unneeded debug printk Olaf Hering
2011-04-01 11:18 ` George Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301656717.9447.89.camel@elijah \
--to=george.dunlap@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.