Re: [PATCH net-next-2.6 4/6] ethtool: Fill out and update comment for struct ethtool_ops

[Ben Hutchings <bhutchings@solarflare.com>]

On Sun, 2011-04-03 at 23:25 +0200, Michał Mirosław wrote:
> 2011/4/3 Ben Hutchings <bhutchings@solarflare.com>:
> > Briefly document all operations (except get_rx_ntuple), including
> > whether they may return an error code and whether they are deprecated.
> > Also mention some things that should be handled by the ethtool core
> > rather than by drivers.
> [...]
> > + * @set_pauseparam: Set pause parameters.  Returns a negative error code
> > + *     or zero.
> > + * @get_rx_csum: Deprecated in favour of the netdev feature %NETIF_F_RXCSUM.
> > + *     Report whether receive checksums are turned on or off.
> > + * @set_rx_csum: Deprecated in favour of the netdev op ndo_set_flags.  Turn
> > + *     receive checksum on or off.  Returns a negative error code or zero.
> 
> Correct op is ndo_set_features and not ndo_set_flags.

That's what I meant.

> This should also
> refer to hw_features field as that's more likely to be the thing
> needed as the replacement.

Agreed.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.