Re: [PATCH] mtd: onenand: add ecclayout and subpage_sft for none-flex 4kb page onenand

[Artem Bityutskiy <dedekind1@gmail.com>]

Hi,

just few minor nit-picks.

Please, try to make the commit subject shorted and less detailed, but
more readable.

On Mon, 2011-04-04 at 14:07 +0300, Roman Tereshonkov wrote: 
>  /**
> + *  onenand_oob_128 - oob info for OneNAND with 4KB page
> + *  and using reserved bytes as free bytes instead of
> + *  free bytes that are managed by ECC.
> + *  For now, we expose only 64 out of 72 ecc bytes
> + */

Do not use /** since this is not a proper kerneldoc comment. Use /*
instead.

Also, make the lines longer - we have 80 characters per line for
comments.

Also, why you use expression "for now" - does it mean you are going to
change this soon? If not, please, amend the comment.

> +static struct nand_ecclayout onenand_oob_128_none_flex = {

none_flex sounds a bit strange. I think it is better to:

1. Re-name onenand_oob_128 into flexonenand_oob_128 (in a separate
patch)
2. Introduce onenand_oob_128

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)