Re: [PATCH 29/46] attr: Fix compilation on uclibc

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2011-03-31 at 21:29 -0700, Khem Raj wrote:
> It needs -lintl added to LDFLAGS for uclibc
> 
> inherit gettext class instead of adding gettext to DEPENDS directly
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-support/attr/attr.inc   |    8 ++++++++
>  meta/recipes-support/attr/ea-acl.inc |    4 +---
>  2 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-support/attr/attr.inc b/meta/recipes-support/attr/attr.inc
> index c110340..3f64ade 100644
> --- a/meta/recipes-support/attr/attr.inc
> +++ b/meta/recipes-support/attr/attr.inc
> @@ -20,3 +20,11 @@ do_install_append() {
>  	sed -i ${D}${libdir}/libattr.la -e \
>  	    s,^libdir=\'${base_libdir}\'$,libdir=\'${libdir}\',
>  }
> +do_configure_append() {
> +        # gettext hack
> +        echo "#define _(str) str" >> ${S}/include/config.h
> +}

No details in the commit log about what this does? It looks likely to
break (e)glibc systems? Perhaps make it libc specific to make it clear
who is using it...

> +# Only append ldflags for target recipe
> +LDFLAGS_libc-uclibc += "${@['', '-lintl']['${PN}' == '${BPN}']}"
> +
> diff --git a/meta/recipes-support/attr/ea-acl.inc b/meta/recipes-support/attr/ea-acl.inc
> index bc93107..a09c31c 100644
> --- a/meta/recipes-support/attr/ea-acl.inc
> +++ b/meta/recipes-support/attr/ea-acl.inc
> @@ -1,11 +1,9 @@
>  # this build system is mostly shared by attr and acl
>  
> -DEPENDS =+ "gettext"
> -
>  SRC_URI += "file://relative-libdir.patch;striplevel=0 \
>              file://no-fixed-prog-path.patch"
>  
> -inherit autotools
> +inherit autotools gettext
>  
>  # the package comes with a custom config.h.in, it cannot be
>  # overwritten by autoheader