From: Artem Bityutskiy <dedekind1@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Paulo Marques <pmarques@grupopie.com>
Subject: Re: [PATCH 2/2] kbuild: move KALLSYMS_EXTRA_PASS from Kconfig to Makefile
Date: Mon, 04 Apr 2011 15:48:04 +0300 [thread overview]
Message-ID: <1301921284.2760.80.camel@localhost> (raw)
In-Reply-To: <4D99B6CC.7080707@suse.cz>
On Mon, 2011-04-04 at 14:17 +0200, Michal Marek wrote:
> > -ifdef CONFIG_KALLSYMS_EXTRA_PASS
> > -last_kallsyms := 3
> > -else
> > last_kallsyms := 2
> > +ifeq ("$(origin KALLSYMS_EXTRA_PASS)", "command line")
>
> I would drop the origin check here. We use it for single-letter
> variables that could be used outside the kernel with a different
> meaning, but if you export KALLSYMS_EXTRA_PASS, then you certainly mean
> the kernel's KALLSYMS_EXTRA_PASS.
Sure, I'll wait if there are more requests and re-send. There is a
missed white-space in the first patch as well which I'll fix.
Thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-04-04 12:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 10:40 [PATCH 1/2] Kconfig: improve KALLSYMS_ALL documentation Artem Bityutskiy
2011-04-04 10:40 ` [PATCH 2/2] kbuild: move KALLSYMS_EXTRA_PASS from Kconfig to Makefile Artem Bityutskiy
2011-04-04 12:17 ` Michal Marek
2011-04-04 12:48 ` Artem Bityutskiy [this message]
2011-04-04 12:45 ` Valdis.Kletnieks
2011-04-04 12:47 ` Artem Bityutskiy
2011-04-04 15:22 ` Valdis.Kletnieks
2011-04-04 15:37 ` Artem Bityutskiy
2011-04-04 16:01 ` Paulo Marques
2011-04-04 15:47 ` Artem Bityutskiy
2011-04-04 16:22 ` [PATCH 1/2] Kconfig: improve KALLSYMS_ALL documentation Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301921284.2760.80.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=pmarques@grupopie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.