From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Q7C06-0000oz-B2 for mharc-grub-devel@gnu.org; Tue, 05 Apr 2011 15:33:18 -0400 Received: from [140.186.70.92] (port=41996 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7C02-0000a6-OA for grub-devel@gnu.org; Tue, 05 Apr 2011 15:33:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7BzY-0005VS-8T for grub-devel@gnu.org; Tue, 05 Apr 2011 15:32:48 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:60767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7BzX-0005Ux-VF for grub-devel@gnu.org; Tue, 05 Apr 2011 15:32:44 -0400 Received: by bwz17 with SMTP id 17so678918bwz.0 for ; Tue, 05 Apr 2011 12:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:subject:from:to:cc:in-reply-to:references :content-type:date:message-id:mime-version:x-mailer; bh=iGznkTWcUDqU7OQ4zy5P4LDxc3v2ks6JO2jxb+9KllI=; b=FDsLIqfRLC4kJ0jNxoZizsrJzLhFeBJhic6RQlL9CY+Glt6K1a32nKxQJ+aJ0bEBE0 kQlTPuw2oQzGJgJg7On83x5Oe4dhenHeapcxnWVf+jQWyIBiLcWGn+dGuVxqg9sX/VsZ uFoE5y0A4/0VPNMZTu7k8OBBPDlHjTQ8yeZOY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer; b=NT13VoonQr8Uyoap4c7t8rzNCkarotifU6fYXFFvXDBYlDJDFK+yYuUK8JNxyDEkSv Zm5EW6RfN29EkfP+vK9DN9OU8xtYsiOy/o1Zdeq7+QaTxdv423FxY0P5SgmaU5VfCjVl VDiHrbxbTw0BEng7GR6RGIgrE6pUM3VNvHa6c= Received: by 10.204.29.18 with SMTP id o18mr77162bkc.12.1302031962764; Tue, 05 Apr 2011 12:32:42 -0700 (PDT) Received: from [192.168.2.2] (p5499C736.dip.t-dialin.net [84.153.199.54]) by mx.google.com with ESMTPS id t1sm3943165bkx.19.2011.04.05.12.32.41 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 05 Apr 2011 12:32:42 -0700 (PDT) From: Alexander Kurtz To: Nicolas de =?ISO-8859-1?Q?Peslo=FCan?= In-Reply-To: <4D9B6A7D.4090306@gmail.com> References: <1302008107.14852.20.camel@alexander> <4D9B6A7D.4090306@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-UX27iVEDm+wHsrHZKurP" Date: Tue, 05 Apr 2011 21:32:40 +0200 Message-ID: <1302031960.30533.7.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.214.41 Cc: The development of GNU GRUB Subject: Re: [PATCH] add proper variable quoting to grub-mkconfig_lib (Debian bug #612417) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2011 19:33:16 -0000 --=-UX27iVEDm+wHsrHZKurP Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Am Dienstag, den 05.04.2011, 21:16 +0200 schrieb Nicolas de Peslo=C3=BCan: > Why do you use construct like "${x}" instead of "$x"? Because code isn't written once and then stays untouched forever. It changes over time and may be used in situations you did not anticipate. Writing solid code (and in shell scripts that definitely includes quoting your variables) avoids unnecessary bugs like this one. I've just seen too many poorly written shell scripts with hidden (sometimes even security-relevant) bugs to not do things properly. And it looks cleaner ;-) Best regards Alexander Kurtz --=-UX27iVEDm+wHsrHZKurP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAABAgAGBQJNm25YAAoJECmUnEL6df6RaYEP/As53uS/8WI6uKGboAarvD0u pV2FNGVvOnan6WQuNz6n9PeGc1yqBa4ToUmilbF4TuJHjqQXiZKoB4gtoDc5DyD2 7SFJZVNxtkRmr0PPfZ91bXEIGUe3blUR1h4baD9TaCtlDI8LQ5azljjQ6mBgIsvC 3HH8IWUc/WR8npm9QR5LYhbwuhMt93vv4lZqpa5g1x4/LMz8ou+fvV2FprWMnYD/ HOzWHza4PCdw41pBQm+G2FfjFxVN1erH/OE2KDY+9EvMS6MNrYBuLCn72GSqASCz O3sXRAcjcDV9Qv4rUWA2ggxzkLbBjp3cfRt7AThGp4B9w3lq6Dq+6Fysduo52e3H /1Jmjcpdq7IfD872MDosa7rT40UQvLGrtH856kWtorr5TYYUAYKuetOiWoBUapDh /Hdt4VxgpCEamzv3IXswsLqTd9OTZJ7OHJMClJ2x7y29ENM4ZSWWUaFuz6bE+EJw UncqR322e3Luptat2mU06F0GmOtI9rxQkWTNKn81VPXvhImPE9WMZyGmxzCHDNE7 cGwJbF4C+cPQieY+T8vhwFoYmLd6Pn2JidVYQf5JFY6NWTSpCyhfL+26OTO0TpvJ RhVQiLbF8rNVPVtm8jYvCwb7XHr9BptZ1jKUSVsW0OTUlYWA8GRGKfaRYJ1ji53+ ijHCY1f/A1O0uGNn5wxr =TjmZ -----END PGP SIGNATURE----- --=-UX27iVEDm+wHsrHZKurP--