From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH] drm/nouveau/hwmon: replace strict_strtol() with kstrtol()
Date: Fri, 7 Feb 2014 00:36:38 -0500 (EST)
Message-ID: <1302089590.26189448.1391751398477.JavaMail.root@redhat.com>
References: <000401cf2216$64ba9c90$2e2fd5b0$%han@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id 1964CFB859
	for <dri-devel@lists.freedesktop.org>;
	Thu,  6 Feb 2014 21:36:43 -0800 (PST)
In-Reply-To: <000401cf2216$64ba9c90$2e2fd5b0$%han@samsung.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Jingoo Han <jg1.han@samsung.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

----- Original Message -----
> From: "Jingoo Han" <jg1.han@samsung.com>
> To: "Ben Skeggs" <bskeggs@redhat.com>
> Cc: dri-devel@lists.freedesktop.org, "David Airlie" <airlied@linux.ie>, "Jingoo Han" <jg1.han@samsung.com>
> Sent: Wednesday, 5 February, 2014 12:02:59 PM
> Subject: [PATCH] drm/nouveau/hwmon: replace strict_strtol() with kstrtol()
> 
> The usage of strict_strtol() is not preferred, because
> strict_strtol() is obsolete. Thus, kstrtol() should be
> used.
> 
Picked it up.  Thanks!

> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_hwmon.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c
> b/drivers/gpu/drm/nouveau/nouveau_hwmon.c
> index 4aff04f..34ad3fa 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c
> @@ -383,8 +383,9 @@ nouveau_hwmon_set_pwm1_enable(struct device *d, struct
> device_attribute *a,
>  	long value;
>  	int ret;
>  
> -	if (strict_strtol(buf, 10, &value) == -EINVAL)
> -		return -EINVAL;
> +	ret = kstrtol(buf, 10, &value);
> +	if (ret)
> +		return ret;
>  
>  	ret = therm->attr_set(therm, NOUVEAU_THERM_ATTR_FAN_MODE, value);
>  	if (ret)
> --
> 1.7.10.4
> 
> 
>