All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: tip: New "Link:" tag to replace "LKML-Reference:"
Date: Thu, 07 Apr 2011 17:03:55 +0200	[thread overview]
Message-ID: <1302188635.9086.44.camel@twins> (raw)
In-Reply-To: <4D9DD08C.2080101@zytor.com>

On Thu, 2011-04-07 at 07:56 -0700, H. Peter Anvin wrote:
> On 04/07/2011 07:54 AM, Peter Zijlstra wrote:
> > 
> > Can't we use a prepare-commit-msg or commit-msg hook to re-write the
> > commit message to include a Link tag when one is missing, using
> > something like:
> > 
> > Link: http://lkml.kernel.org/r/tip-$SHA@git.kernel.org
> > 
> > And have the post-commit hook that sends the messages recognize this
> > form and send the message using the correct msgid.
> > 
> > That way the commit includes a correct and clickable link, doesn't
> > require magic knowledge and doesn't need the committer to do extra work.
> > 
> 
> Think about it... hint: the SHA1 is a cryptographically secure signature
> of the commit object.

D'0h ok.. but the scheme would work with any generated msgid, all we
need is to generate one for commits that lack a Link tag and insert it
using the prepare-commit-msg/commit-msg hooks and for the post-commit
hook to recognize it and use that actual msgid.

The only thing to avoid is msgid collision, but given that MUAs already
have this problem all we need to do is borrow some of their logic.

  reply	other threads:[~2011-04-07 15:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06 22:09 tip: New "Link:" tag to replace "LKML-Reference:" H. Peter Anvin
2011-04-07 14:08 ` Peter Zijlstra
2011-04-07 14:43   ` H. Peter Anvin
2011-04-07 14:54     ` Peter Zijlstra
2011-04-07 14:56       ` H. Peter Anvin
2011-04-07 15:03         ` Peter Zijlstra [this message]
2011-04-07 15:20           ` H. Peter Anvin
2011-04-07 15:26             ` Peter Zijlstra
2011-04-08 19:05             ` Link: tags for new submission -- UPDATE H. Peter Anvin
2011-04-07 15:03       ` tip: New "Link:" tag to replace "LKML-Reference:" H. Peter Anvin
2011-04-07 15:28 ` Sam Ravnborg
2011-04-07 15:58   ` H. Peter Anvin
2011-04-08 14:36 ` Bjorn Helgaas
2011-04-08 18:45   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302188635.9086.44.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.